Markus PR-2.1 review

.github/workflows/build.yml

@@ -28,7 +28,8 @@ jobs:
         test -f VOEvent.pdf
         test -f VOEvent.bbl
 
-    - uses: actions/upload-artifact@v1
+    - name: Keep the PDF artefact
+      uses: actions/upload-artifact@v4
       with:
         name: PDF Preview
-        path: VOEvent.pdf
+        path: ${{ env.doc_name }}.pdf

.gitignore

@@ -11,3 +11,6 @@ ivoatexmeta.tex
 *.tar.gz
 *.swp
 role_diagram.svg
+gitmeta.tex
+*.fdb_latexmk
+*.fls

Makefile

@@ -18,17 +18,27 @@ [email protected]
 
 # Source files for the TeX document (but the main file must always
 # be called $(DOCNAME).tex
-SOURCES = $(DOCNAME).tex role_diagram.pdf
+SOURCES = $(DOCNAME).tex role_diagram.pdf gitmeta.tex
 
 # List of image files to be included in submitted package (anything that
 # can be rendered directly by common web browsers)
 FIGURES = role_diagram.svg
 
 # List of PDF figures (figures that must be converted to pixel images to
 # work in web browsers).
-VECTORFIGURES = 
+VECTORFIGURES =
 
 # Additional files to distribute (e.g., CSS, schema files, examples...)
 AUX_FILES = VOEvent-v2.1.xsd VOEventRegExt-v2.0.xsd resrec-sample.vor
 
 include ivoatex/Makefile
+
+-include ivoatex/Makefile
+
+ivoatex/Makefile:
+	@echo "*** ivoatex submodule not found.  Initialising submodules."
+	@echo
+	git submodule update --init
+
+test:
+	@echo "No tests defined yet"

VOEvent-v2.1.xsd

@@ -18,7 +18,7 @@ Revision 2.1 2020/05/05 BaptisteCecconi
 - added "coord_value" type introducing "ucd" and "unit" attributes for C1, C2 and C3 elements
 - added "error2" type, with "C1" and "C2" elements
 - added "error3" type, with "C1", "C2" and "C3" elements
-- added "TimeFrameType" (taken from to STC-1.30) 
+- added "TimeFrameType" (taken from to STC-1.30)
 - added "SpaceFrameType" (taken from to STC-1.30)
 -->
 <xs:schema xmlns="http://www.ivoa.net/xml/VOEvent/v2.1" xmlns:xs="http://www.w3.org/2001/XMLSchema"

VOEventRegExt-v2.0.xsd

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema" 
+<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema"
            xmlns:vr="http://www.ivoa.net/xml/VOResource/v1.0"
            xmlns:voe="http://www.ivoa.net/xml/VOEventRegExt/v2"
            xmlns:vm="http://www.ivoa.net/xml/VOMetadata/v0.1"
@@ -41,7 +41,7 @@
                      A URI of the standard or convention this endpoint follows.
                   </xs:documentation>
                   <xs:documentation>
-                     This will normally be a key from 
+                     This will normally be a key from
                      ivo://ivoa.net/std/VOEvent starting with acc-.
                   </xs:documentation>
                </xs:annotation>