Markus PR-2.1 review #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(who also takes the liberty of adding himself to the author list here: I've contributed the Registry chapter)
BaptisteCecconi
previously approved these changes
Nov 4, 2024
BaptisteCecconi
approved these changes
Nov 17, 2024
|
@molinaro-m @pdowler I can't merge that PR. Any reason why? Can you do it for me? |
|
@BaptisteCecconi I've just changed something in the configuration of this repo. Can you see if you can merge now? If it does not work for you, I'll merge it myself 😉 |
|
I can merge now. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bunch of hopefully uncontroversial changes, in particular creating a chapter on the Role within the VO and trying format the code examples somewhat nicer (to my eyes).
Please ignore commit 22a155a (which only removes trailing blanks) and review only commit 200aba5.