Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend/frontend): 3256 able to view deleted tenant #3299

Merged
merged 4 commits into from
Feb 14, 2025
Merged

feat(backend/frontend): 3256 able to view deleted tenant #3299

merged 4 commits into from
Feb 14, 2025

Conversation

koekiebox
Copy link
Collaborator

@koekiebox koekiebox commented Feb 13, 2025 •
edited
Loading

Changes proposed in this pull request

Context

Fixes #3256

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@koekiebox koekiebox self-assigned this Feb 13, 2025
@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic pkg: auth Changes in the GNAP auth package. type: localenv Local playground pkg: mock-ase pkg: documentation Changes in the documentation package. pkg: mock-account-service-lib labels Feb 13, 2025
@koekiebox koekiebox mentioned this pull request Feb 13, 2025
Closed
2 tasks
@netlify Netlify
Copy link

netlify bot commented Feb 13, 2025 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec ready!

Name Link
🔨 Latest commit c3e7a55
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/67ade78d3f098300088d3f47
😎 Deploy Preview https://deploy-preview-3299--brilliant-pasca-3e80ec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@koekiebox koekiebox requested a review from mkurapov February 13, 2025 12:46
@koekiebox koekiebox changed the base branch from main to 2893/multi-tenancy-v1 February 13, 2025 12:47
@github-actions github-actions bot removed pkg: auth Changes in the GNAP auth package. type: localenv Local playground pkg: mock-ase pkg: documentation Changes in the documentation package. pkg: mock-account-service-lib labels Feb 13, 2025
@koekiebox koekiebox marked this pull request as ready for review February 13, 2025 13:19
@mkurapov mkurapov linked an issue Feb 13, 2025 that may be closed by this pull request
[Multi-Tenant] Allow viewing deleted tenants #3256
Closed
2 tasks
@koekiebox koekiebox requested a review from mkurapov February 14, 2025 11:30
mkurapov
mkurapov reviewed Feb 14, 2025
View reviewed changes
Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@koekiebox koekiebox requested a review from mkurapov February 14, 2025 13:49
@koekiebox koekiebox merged commit f3cae25 into 2893/multi-tenancy-v1 Feb 14, 2025
25 of 37 checks passed
@koekiebox koekiebox deleted the feature/3256-view-deleted-tenant branch February 14, 2025 16:28
@golobitch golobitch mentioned this pull request Mar 1, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurapov mkurapov mkurapov approved these changes

Assignees

@koekiebox koekiebox

Labels
pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Multi-Tenant] Allow viewing deleted tenants
2 participants
@koekiebox @mkurapov