Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multi-Tenant] Allow viewing deleted tenants #3256

Closed
2 tasks done
Tracked by #2893
mkurapov opened this issue Jan 30, 2025 · 2 comments · Fixed by #3299
Closed
2 tasks done
Tracked by #2893

[Multi-Tenant] Allow viewing deleted tenants #3256

mkurapov opened this issue Jan 30, 2025 · 2 comments · Fixed by #3299
Assignees
Labels
type: enhancement New feature or request

Comments

@mkurapov
Copy link
Contributor

mkurapov commented Jan 30, 2025

Context

Currently, if a tenant is deleted, it is not possible to fetch it using the tenant query.
However, this doesn't play nicely with the Admin UI: you are unable to navigate to the tenant details screen from the tenant list page.

If you are the operator tenant, we should allow fetching deleted tenants, and being able to view details.

Todos

  • Allow the tenant Admin API resolver to return deleted tenants if an operator is making the request.
  • Allow clicking into tenant details in the Admin UI for deleted tenants. The fields should not be editable.

PR:

#3299

@mkurapov
Copy link
Contributor Author

mkurapov commented Feb 5, 2025

@koekiebox koekiebox self-assigned this Feb 11, 2025
@koekiebox koekiebox moved this from Backlog to In Progress in Rafiki Feb 11, 2025
@koekiebox koekiebox added the type: enhancement New feature or request label Feb 13, 2025
@koekiebox
Copy link
Collaborator

View for an active tenant:

Image

View only for a deleted tenant:
Image

@koekiebox koekiebox moved this from In Progress to Ready for Review in Rafiki Feb 13, 2025
@mkurapov mkurapov linked a pull request Feb 13, 2025 that will close this issue
6 tasks
@koekiebox koekiebox moved this from Ready for Review to Done in Rafiki Feb 14, 2025
@koekiebox koekiebox closed this as completed by moving to Done in Rafiki Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants