Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new regexp to the r-cmd-check-note blocklist #291

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

llrs-roche
Copy link
Contributor

This PR is to add the notes to the CI part per #288 but only for teal.reporter.

The changes do not look to the general issue as vignettes failing to build could be due to a number of reasons. As far as I know the string I added is specific for this error. To fix the issue PR #290 was already merge so I don't expect any failures now.

This could be added to the default/general check from r.pkg.template if it meets the IDR requirements.

@llrs-roche llrs-roche linked an issue Nov 28, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

github-actions bot commented Nov 28, 2024

badge

Code Coverage Summary

Filename                  Stmts    Miss  Cover    Missing
----------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------
R/AddCardModule.R           146       2  98.63%   170, 207
R/ContentBlock.R             18       2  88.89%   57-63
R/DownloadModule.R          238      67  71.85%   98-104, 152, 183-188, 197-202, 205-210, 219-224, 227-232, 240-245, 248-253, 260-265, 268-273, 312-316
R/FileBlock.R                13       0  100.00%
R/LoadReporterModule.R      103      19  81.55%   100-105, 108-113, 119-124, 136
R/NewpageBlock.R              2       0  100.00%
R/PictureBlock.R             30       2  93.33%   20, 118
R/Previewer.R               372      95  74.46%   96-98, 101-102, 184-213, 217-219, 222, 289, 304, 306-309, 312, 315-323, 437-481
R/RcodeBlock.R               15       0  100.00%
R/Renderer.R                113      37  67.26%   97-112, 216, 224, 233, 235-256
R/ReportCard.R               84       3  96.43%   239, 244, 269
R/Reporter.R                107       6  94.39%   273-278
R/ResetModule.R              53       0  100.00%
R/SimpleReporter.R           32       0  100.00%
R/TableBlock.R                9       0  100.00%
R/TextBlock.R                13       0  100.00%
R/utils.R                   126      86  31.75%   7, 38-97, 99, 102-109, 137, 161-169, 206-215
R/yaml_utils.R               81       2  97.53%   78, 289
R/zzz.R                      14      10  28.57%   2-13, 19
TOTAL                      1569     331  78.90%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 5bd4f88

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Nov 28, 2024

Unit Tests Summary

  1 files   19 suites   29s ⏱️
197 tests 197 ✅ 0 💤 0 ❌
337 runs  337 ✅ 0 💤 0 ❌

Results for commit 28becab.

♻️ This comment has been updated with latest results.

@llrs-roche
Copy link
Contributor Author

Hi @insightsengineering/idr I provided this PR to check on all packages the vignettes issues, is this the way to go? If this is the way I'll provide another one on a different PR for "Please provide package anchors for all Rd \link{} targets not in the package itself and the base packages." which was recently observed in different packages, for example in insightsengineering/teal.modules.general#813

@llrs-roche
Copy link
Contributor Author

Thanks @cicdguy for approving this. I'll open a PR to r.pkg.template too

@llrs-roche llrs-roche merged commit e2216eb into main Jan 29, 2025
27 checks passed
@llrs-roche llrs-roche deleted the blocking_notes@main branch January 29, 2025 16:04
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R CMD CHECK note
3 participants