Skip to content

Commit

Permalink
Add a new regexp to the r-cmd-check-note blocklist (#291)
Browse files Browse the repository at this point in the history
This PR is to add the notes to the CI part per
#288 but only
for teal.reporter.

The changes do not look to the general issue as vignettes failing to
build could be due to a number of reasons. As far as I know the string I
added is specific for this error. To fix the issue PR #290 was already
merge so I don't expect any failures now.

This could be added to the default/general check from r.pkg.template if
it meets the IDR requirements.

---------

Signed-off-by: Lluís Revilla <[email protected]>
Co-authored-by: Marcin <[email protected]>
  • Loading branch information
llrs-roche and m7pr authored Jan 29, 2025
1 parent a953ab3 commit e2216eb
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ jobs:
checking Rd .usage sections .* NOTE
checking for unstated dependencies in vignettes .* NOTE
checking top-level files .* NOTE
Files named as vignettes but with no recognized vignette engine.* NOTE
unit-test-report-brand: >-
https://raw.githubusercontent.com/insightsengineering/hex-stickers/main/thumbs/teal.png
deps-installation-method: setup-r-dependencies
Expand Down Expand Up @@ -68,6 +69,7 @@ jobs:
checking Rd .usage sections .* NOTE
checking for unstated dependencies in vignettes .* NOTE
checking top-level files .* NOTE
Files named as vignettes but with no recognized vignette engine.* NOTE
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/rlistings
Expand Down

0 comments on commit e2216eb

Please sign in to comment.