Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _standalone.html #1269

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Update _standalone.html #1269

merged 1 commit into from
Jan 28, 2025

Conversation

Delphineray
Copy link
Contributor

@Delphineray Delphineray commented Jan 27, 2025

Mini modifications suite à PR : #1257

Description succincte du problème résolu

Carte Notion : https://www.notion.so/accelerateur-transition-ecologique-ademe/Existe-aussi-en-prod-Changer-quand-m-me-dans-footer-Que-faire-de-mes-d-chets-je-1826523d57d78094aaa4f8435aa42528?pvs=4

Description plus détaillée de l'intention, l'approche ou de l'implémentation (ce qui n’est pas visible directement en lisant le code)

Type de changement :

  • Bug fix
  • Nouvelle fonctionnalité
  • Mise à jour de données / DAG
  • Les changements nécessitent une mise à jour de documentation
  • Refactoring de code (explication à retrouver dans la description)

Auto-review

Les trucs à faire avant de demander une review :

  • J'ai bien relu mon code
  • La CI passe bien
  • En cas d'ajout de variable d'environnement, j'ai bien mis à jour le .env.template
  • J'ai ajouté des tests qui couvrent le nouveau code

Comment tester

En local / staging :

@Delphineray Delphineray requested a review from a team as a code owner January 27, 2025 19:59
@Delphineray Delphineray requested review from kolok and fabienheureux and removed request for a team and kolok January 27, 2025 19:59
@fabienheureux fabienheureux enabled auto-merge (squash) January 27, 2025 22:35
Mini modifications suite à PR : #1257
@kolok kolok force-pushed the Delphineray-patch-5 branch from 635f1ba to d5df708 Compare January 28, 2025 10:34
@kolok kolok enabled auto-merge (squash) January 28, 2025 10:34
@kolok kolok merged commit c301d4c into main Jan 28, 2025
11 checks passed
@kolok kolok deleted the Delphineray-patch-5 branch January 28, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants