utiliser modification plutôt que mises à jour

dags/sources/config/shared_constants.py

@@ -16,7 +16,7 @@
 # SuggestionCohorte actions
 SUGGESTION_CLUSTERING = "CLUSTERING"
 SUGGESTION_SOURCE_AJOUT = "SOURCE_AJOUT"
-SUGGESTION_SOURCE_MISESAJOUR = "SOURCE_MISESAJOUR"
+SUGGESTION_SOURCE_MODIFICATION = "SOURCE_MODIFICATION"
 SUGGESTION_SOURCE_SUPRESSION = "SOURCE_SUPRESSION"
 
 # Public accueilli

dags/sources/tasks/business_logic/db_write_type_action_suggestions.py

@@ -40,7 +40,7 @@ def db_write_type_action_suggestions(
         metadata=metadata,
         dag_name=f"{dag_name} - MISES A JOUR",
         run_name=run_name,
-        type_action=constants.SUGGESTION_SOURCE_MISESAJOUR,
+        type_action=constants.SUGGESTION_SOURCE_MODIFICATION,
     )
 
 

dags/suggestions/tasks/business_logic/db_normalize_suggestion.py

@@ -29,7 +29,7 @@ def db_normalize_suggestion():
         type_action
         in [
             constants.SUGGESTION_SOURCE_AJOUT,
-            constants.SUGGESTION_SOURCE_MISESAJOUR,
+            constants.SUGGESTION_SOURCE_MODIFICATION,
         ]
         and not df_sql.empty
     ):

dags/suggestions/tasks/business_logic/db_write_validsuggestions.py

@@ -28,7 +28,7 @@ def db_write_validsuggestions(data_acteurs_normalized: dict):
     with engine.begin() as connection:
         if change_type in [
             constants.SUGGESTION_SOURCE_AJOUT,
-            constants.SUGGESTION_SOURCE_MISESAJOUR,
+            constants.SUGGESTION_SOURCE_MODIFICATION,
         ]:
             db_write_acteurupdate(
                 connection, df_actors, df_labels, df_acteur_services, df_pds, df_pdssc

data/migrations/0002_tables_suggestion.py

@@ -45,7 +45,7 @@ class Migration(migrations.Migration):
                                 "ingestion de source de données - nouveau acteur",
                             ),
                             (
-                                "SOURCE_MISESAJOUR",
+                                "SOURCE_MODIFICATION",
                                 "ingestion de source de données - modification d'acteur existant",
                             ),
                             ("SOURCE_SUPRESSION", "ingestion de source de données"),

data/models.py

@@ -11,7 +11,7 @@
     SUGGESTION_PARTIEL,
     SUGGESTION_REJETEE,
     SUGGESTION_SOURCE_AJOUT,
-    SUGGESTION_SOURCE_MISESAJOUR,
+    SUGGESTION_SOURCE_MODIFICATION,
     SUGGESTION_SOURCE_SUPRESSION,
     SUGGESTION_SUCCES,
 )
@@ -34,8 +34,8 @@ class SuggestionAction(models.TextChoices):
         SUGGESTION_SOURCE_AJOUT,
         "ingestion de source de données - nouveau acteur",
     )
-    SOURCE_MISESAJOUR = (
-        SUGGESTION_SOURCE_MISESAJOUR,
+    SOURCE_MODIFICATION = (
+        SUGGESTION_SOURCE_MODIFICATION,
         "ingestion de source de données - modification d'acteur existant",
     )
     SOURCE_SUPPRESSION = SUGGESTION_SOURCE_SUPRESSION, "ingestion de source de données"
@@ -72,7 +72,7 @@ class SuggestionCohorte(TimestampedModel):
     def is_source_type(self) -> bool:
         return self.type_action in [
             SuggestionAction.SOURCE_AJOUT,
-            SuggestionAction.SOURCE_MISESAJOUR,
+            SuggestionAction.SOURCE_MODIFICATION,
             SuggestionAction.SOURCE_SUPPRESSION,
         ]
 

data/views.py

@@ -14,7 +14,7 @@
 ACTION_TO_VERB = {
     SuggestionAction.SOURCE_AJOUT: "ajoutera",
     SuggestionAction.SOURCE_SUPPRESSION: "supprimera",
-    SuggestionAction.SOURCE_MISESAJOUR: "mettra à jour",
+    SuggestionAction.SOURCE_MODIFICATION: "modifiera",
 }
 
 

templates/data/_partials/source_event.html

@@ -10,7 +10,7 @@ <h3>Exemples</h3>
 <div class="fr-table">
     <table>
         <caption>Suggestion de source à valider</caption>
-        {% if suggestion_cohorte_instance.type_action == "SOURCE_AJOUT" or suggestion_cohorte_instance.type_action == "SOURCE_MISESAJOUR" %}
+        {% if suggestion_cohorte_instance.type_action == "SOURCE_AJOUT" or suggestion_cohorte_instance.type_action == "SOURCE_MODIFICATION" %}
             {% include 'data/_partials/source_ajout_event.html' %}
         {% elif suggestion_cohorte_instance.type_action == "SOURCE_SUPRESSION" %}
         {% include 'data/_partials/source_supression_event.html' %}

unit_tests/data/test_models.py

@@ -10,7 +10,7 @@
     "type_action, expected_result",
     [
         (SuggestionAction.SOURCE_AJOUT, True),
-        (SuggestionAction.SOURCE_MISESAJOUR, True),
+        (SuggestionAction.SOURCE_MODIFICATION, True),
         (SuggestionAction.SOURCE_SUPPRESSION, True),
         (SuggestionAction.CLUSTERING, False),
         ("other_action", False),
@@ -26,7 +26,7 @@ def test_is_source_type(type_action, expected_result):
     [
         (SuggestionAction.CLUSTERING, True),
         (SuggestionAction.SOURCE_AJOUT, False),
-        (SuggestionAction.SOURCE_MISESAJOUR, False),
+        (SuggestionAction.SOURCE_MODIFICATION, False),
         (SuggestionAction.SOURCE_SUPPRESSION, False),
         ("other_action", False),
     ],