Début de la refactorisation de l'interface dags/validations #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolok
force-pushed
the
remove_column_mapping2
branch
2 times, most recently
from
4973fba to
dbf5c30
Compare
kolok
force-pushed
the
better_validation
branch
2 times, most recently
from
9d49e48 to
a908b79
Compare
kolok
force-pushed
the
remove_column_mapping2
branch
from
0f27d75 to
be97c03
Compare
kolok
force-pushed
the
better_validation
branch
from
a908b79 to
ac74dd8
Compare
kolok
force-pushed
the
better_validation
branch
from
ac74dd8 to
acb6123
Compare
|
kolok
commented
Jan 8, 2025
3 tasks
kolok
force-pushed
the
better_validation
branch
4 times, most recently
from
c701399 to
d0ab227
Compare
kolok
requested review from
fabienheureux and
maxcorbeau
and removed request for
a team
kolok
force-pushed
the
better_validation
branch
from
26a7831 to
7b31185
Compare
Co-authored-by: Fabien Le Frapper <[email protected]>
kolok
force-pushed
the
better_validation
branch
from
f839697 to
39716f0
Compare
| # SuggestionCohorte actions | ||
| SUGGESTION_CLUSTERING = "CLUSTERING" | ||
| SUGGESTION_SOURCE_AJOUT = "SOURCE_AJOUT" | ||
| SUGGESTION_SOURCE_MISESAJOUR = "SOURCE_MISESAJOUR" |
There was a problem hiding this comment.
Suggested change
| SUGGESTION_SOURCE_MISESAJOUR = "SOURCE_MISESAJOUR" | |
| SUGGESTION_SOURCE_MISEAJOUR = "SOURCE_MISEAJOUR" |
Comment on lines
+28
to
+30
| raise ValueError("df_acteur est vide") | ||
| if df_acteur_services.empty: | ||
| raise ValueError("df_acteur_services est vide") |
There was a problem hiding this comment.
Remarque : tous mes logs / exceptions sont en anglais, il faudrait qu'on définisse une petite convention là dessus
fabienheureux
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description succincte du problème résolu
Carte Notion : LVAO : outil de validation : améliorations à prévoir
Je conseille de démarrer la revue par le système de revue des suggestions dans la nouvelle app django
dataet en particulier par les modèles. :data/models.pyLa documentation du système de suggestion est disponible ici :
docs/reference/303-systeme-de-suggestions.mdA discuter :
On assume de casser la fonctionnalité de
siretisationqui n'est buggé et pas bien maitrisé par les équipesReste quelques FIXME : est-ce des pré-requis avant le merge de cette PR
Bug : Drop-down du haut : passer d’une cohorte à l’autre ne rafraichit pas la cohorte affichée en dessous (obligé de revenir à la racine via l’URL dans la barre d’adresse) - Semble résolu ? Edit : 16/09 : Non, je repro à nouveau
Type de changement :
Auto-review
Les trucs à faire avant de demander une review :
.env.templateComment tester
En local / staging :