-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Column
class entirely
#157
base: enh/introduce-has-solution
Are you sure you want to change the base?
Remove Column
class entirely
#157
Conversation
@@ -25,7 +23,7 @@ class VariableCreateInput(BaseModel): | |||
|
|||
|
|||
class DataInput(BaseModel): | |||
data: dict[str, Any] | |||
data: dict[str, list[float] | list[int] | list[str]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this to reflect the other changes, then run into the thing that the tests on the REST API platforms always converted data to dict[str, list[float]]
for some reason. I don't understand why, but it doesn't seem to be this change because the same happens for equations. Still, to show that, I didn't also change the other type hints in this layer, though I suppose I still could.
aec6d3a
to
9c36f7a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## enh/introduce-has-solution #157 +/- ##
============================================================
- Coverage 88.4% 88.4% -0.1%
============================================================
Files 231 223 -8
Lines 8113 8032 -81
============================================================
- Hits 7179 7103 -76
+ Misses 934 929 -5
|
As discovered in #151, using sqlalchemy's associationproxies is both (a bit) more performant and (considerably) less confusing than having a DB table called
Column
. Thus, this PR completes the removal of this construct.TODO
Column
class forParameter
#156 gets its own migrations firstOn top of this, the PR includes a few minor fixes:
.data
in the core layer more accuratetype: ignores
by casting appropriatelyVariable.indexsets
None
when appropriate.set_creation_info()
callsrun.optimization.remove_solution()
#139 and never skipped for tables, even when{}
was added)