Fix actual return type of column_names
property
#162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncovered another bug introduced by #156 and #157: previously, I returned the
column_names
property as acast(list[str], ...)
of the underlying sqlalchemy collection. Mypy understood this just fine, but the actual type of the return object was not changed, it was just made to look that way. This created an error inpd.DataFrame().set_index()
as this function does not know how to handle sqlalchemy's_AssociationList
objects.This PR fixes this bug by explicitly creating the return object as a
list[str]
. Thefor
loop should be fine as no item should have more than 12column_names
in practice. It also adds tests to ensure this behaviour doesn't break again in the future.