Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

231-hot-water-accessory-migration-to-myuplink #233

Merged
merged 8 commits into from
Oct 20, 2024
Merged

231-hot-water-accessory-migration-to-myuplink #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cc7671c
feature(hotwater): New accessory
Sep 28, 2024
15566c2
feature(hotwater): New accessory
Sep 28, 2024
49d9f66
feature(hotwater): New accessory
Sep 28, 2024
eb655dc
feature(hotwater): New accessory
Sep 30, 2024
7d9e837
feature(hotwater): New accessory
Oct 1, 2024
3b36cb7
feature(hotwater): New accessory
Oct 1, 2024
805268e
feature(hotwater): New accessory
Oct 13, 2024
8d5699d
feature(hotwater): New accessory
Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ Complete setup instructions are available on the plugin configuration page in Ho
<td>BT1 average outdoor temperature (40067).</td>
</tr>
<tr>
<td>hot-water (Soon)</td>
<td>Hot water temperature (40014,40008). Active (on/off) is responsible for temporary lux (48132).</td>
<td>hot-water</td>
<td>Thermostat for hot water (40014, 40008). The switch within the thermostat controls temporary lux (48132), which requires a Nibe premium subscription. Changing temporary lux through the Nibe API takes some time (20-30 seconds), so any switch adjustments won’t be immediately reflected in Nibe.</td>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
If specifying a range, consider using an en dash instead of a hyphen. (HYPHEN_TO_EN[1])
Suggestions: 20–30
URL: https://languagetool.org/insights/post/dashes/#how-to-properly-use-an-en-dash
Rule: https://community.languagetool.org/rule/show/HYPHEN_TO_EN?lang=en-US&subId=1
Category: PUNCTUATION

</tr>
<tr>
<td>hot-water-top</td>
Expand Down
13 changes: 1 addition & 12 deletions archive/Provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,7 @@
// public abstract provide(parameters: Map<number, Parameter>, providerParameters: any, platform: PlatformAdapter): any;
// }
//
// class MaxValue extends Provider {
// public provide(parameters: Map<number, Parameter>, providerParameters: any, platform: PlatformAdapter) {
// let max;
// for (const id of providerParameters.ids) {
// const param = parameters.get(id);
// if (param && param.value && (max === undefined || param.value > max)) {
// max = param.value;
// }
// }
// return max;
// }
// }

//
// class VentilationRotationSpeedStepSetter extends MaxValue {
// public provide(parameters: Map<number, Parameter>, providerParameters: any, platform: PlatformAdapter) {
Expand Down
18 changes: 0 additions & 18 deletions archive/accessories.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@
accessoriesConfiguration:
- id: hot-water
name: hot-water
condition:
parameterIds: [ 40014, 40008 ]
services:
- type: HeaterCooler
characteristics:
- type: CurrentTemperature
id: 40014
refresh: true
- type: Active
id: 48132
mapper:
Expand Down Expand Up @@ -42,18 +36,6 @@ accessoriesConfiguration:
minValue: 0
validValues: [ 0 ]
perms: [ "pr", "ev" ]
- type: TemperatureDisplayUnits
id: 40014
attribute: unit
mapper:
- "°F": 1
- "default": 0
props:
perms: [ "pr", "ev" ]
refresh: true
- type: Name
value: temperature.current.name
translate: true
- type: HeatingThresholdTemperature
provider:
name: MaxValue
Expand Down
8 changes: 3 additions & 5 deletions lang/en.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,9 @@ ventilation-extract-air-40026: Nibe extract air temperature
ventilation-supply-air-40075: Nibe supply air temperature
ventilation-outdoor-40183: Nibe ventilation outdoor temperature
hot-water-top-40013: Nibe top hot water temperature

hot-water:
temperature.current.name: Nibe hot water temperature
hot-water-temporary-lux:
name: Nibe hot water temporary lux
hot-water: Nibe hot water temperature
hot-water-temp-lux: Temporary Lux
new-firmware: Update

ers-fan:
fan.name: Nibe ERS
Expand Down
8 changes: 3 additions & 5 deletions lang/pl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,11 @@ ventilation-extract-air-40026: Nibe temperatura powietrza usuwanego
ventilation-supply-air-40075: Nibe temperatura powietrza nawiewanego
ventilation-outdoor-40183: Nibe temperatura zewnętrzna z wentylacji
hot-water-top-40013: Nibe najwyższa temperatura C.W.U.
hot-water: Nibe temperatura C.W.U.
hot-water-temp-lux: Tymczasowy luksus
new-firmware: Aktualizacja


hot-water:
temperature.current.name: Nibe temperatura C.W.U.
hot-water-temporary-lux:
name: Nibe C.W.U. tymczasowy luksus

ers-fan:
fan.name: Nibe ERS
ventilation-fan:
Expand Down
8 changes: 3 additions & 5 deletions lang/sv.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,9 @@ ventilation-extract-air-40026: Nibe avluft
ventilation-supply-air-40075: Nibe tillufttemperatur
ventilation-outdoor-40183: Nibe ventilation utetemperatur
hot-water-top-40013: Nibe varmvatten topp

hot-water:
temperature.current.name: Nibe varmvatten laddning
hot-water-temporary-lux:
name: Nibe varmvatten tillfällig lux
hot-water: Nibe varmvatten laddning
hot-water-temp-lux: Tillfällig Lux
new-firmware: Uppdatering

ers-fan:
fan.name: Nibe ERS
Expand Down
Loading
Loading