231-hot-water-accessory-migration-to-myuplink #233
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -4,12 +4,21 @@ import {Locale} from './util/Locale'; | |||
|
|
|||
| export interface AccessoryInstance { | |||
| context: AccessoryContext | |||
| getService(type: any): ServiceInstance; | |||
| getService(type: any): ServiceInstance | undefined; | |||
There was a problem hiding this comment.
Unexpected any. Specify a different type.
| } | ||
|
|
||
| export interface ServiceInstance { | ||
| updateCharacteristic(type: any, value: any): void; | ||
| addOptionalCharacteristic(type: any); |
There was a problem hiding this comment.
Unexpected any. Specify a different type.
| } | ||
|
|
||
| export interface ServiceInstance { | ||
| updateCharacteristic(type: any, value: any): void; | ||
| addOptionalCharacteristic(type: any); | ||
| getCharacteristic(type: any): CharacteristicInstance; |
There was a problem hiding this comment.
Unexpected any. Specify a different type.
| } | ||
|
|
||
| export interface CharacteristicInstance { | ||
| setProps(props: any): CharacteristicInstance; |
There was a problem hiding this comment.
Unexpected any. Specify a different type.
|
|
||
| export interface CharacteristicInstance { | ||
| setProps(props: any): CharacteristicInstance; | ||
| value: any; |
There was a problem hiding this comment.
Unexpected any. Specify a different type.
| this.serviceResolver, | ||
| this.log, | ||
| { hotWaterHeatingTemp: config.hotwaterHeatingTemp || 40 }, | ||
| async (deviceId: string, paramId: string, value: any) => { |
There was a problem hiding this comment.
Unexpected any. Specify a different type.
| @@ -201,6 +245,37 @@ export class MyUplinkApiFetcher extends EventEmitter implements DataFetcher { | |||
| } | |||
| } | |||
|
|
|||
| public async setValue(deviceId: string, paramId: string, value: any): Promise<void> { | |||
There was a problem hiding this comment.
Unexpected any. Specify a different type.
| protected readonly serviceResolver: ServiceResolver, | ||
| protected readonly log: Logger, | ||
| protected readonly config: { hotWaterHeatingTemp: number }, | ||
| protected readonly setValue: (deviceId: string, paramId: string, value: any) => Promise<void>, |
There was a problem hiding this comment.
Unexpected any. Specify a different type.
| super(name, version, locale, serviceResolver, log); | ||
| } | ||
|
|
||
| isApplicable(data: Data): boolean { |
There was a problem hiding this comment.
'data' is defined but never used.
| export class Cache { | ||
|
|
||
| private readonly store: { | ||
| [key: string]: {ttl: number, value: any}; |
There was a problem hiding this comment.
Unexpected any. Specify a different type.
| <td>hot-water (Soon)</td> | ||
| <td>Hot water temperature (40014,40008). Active (on/off) is responsible for temporary lux (48132).</td> | ||
| <td>hot-water</td> | ||
| <td>Thermostat for hot water (40014, 40008). The switch within the thermostat controls temporary lux (48132), which requires a Nibe premium subscription. Changing temporary lux through the Nibe API takes some time (20-30 seconds), so any switch adjustments won’t be immediately reflected in Nibe.</td> |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
If specifying a range, consider using an en dash instead of a hyphen. (HYPHEN_TO_EN[1])
Suggestions: 20–30
URL: https://languagetool.org/insights/post/dashes/#how-to-properly-use-an-en-dash
Rule: https://community.languagetool.org/rule/show/HYPHEN_TO_EN?lang=en-US&subId=1
Category: PUNCTUATION
No description provided.