Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pihole): add support for v6 #2448

Merged
merged 7 commits into from
Mar 4, 2025
Merged

feat(pihole): add support for v6 #2448

merged 7 commits into from
Mar 4, 2025

Conversation

Meierschlumpf
Copy link
Member

@Meierschlumpf Meierschlumpf commented Feb 28, 2025


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm build, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Closes #2367

@Meierschlumpf Meierschlumpf added enhancement New feature or request blocked Blocked by something external / internal labels Feb 28, 2025
@Meierschlumpf Meierschlumpf self-assigned this Feb 28, 2025
Copy link

deepsource-io bot commented Feb 28, 2025

Here's the code health analysis summary for commits 7dfb108..0d939c2. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Feb 28, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 23.33% 9897 / 42417
🔵 Statements 23.33% 9897 / 42417
🔵 Functions 30.15% 415 / 1376
🔵 Branches 65.05% 1186 / 1823
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/api/src/router/integration/integration-router.ts 48.43% 83.33% 100% 48.43% 78-123, 128-132, 136-142, 160-164, 235-239, 293-297, 302-370, 375-416, 421-462, 468-469, 508-520
packages/api/src/router/integration/integration-test-connection.ts 85.71% 83.33% 100% 85.71% 43-47, 89-90, 110-111
packages/api/src/router/search-engine/search-engine-router.ts 22.59% 100% 100% 22.59% 15-27, 32-41, 45-68, 71-116, 119-131, 137-138, 144-145, 151-160, 166-187, 193-199
packages/api/src/router/widgets/dns-hole.ts 33.33% 100% 100% 33.33% 19-35, 41-62, 68-75, 86-93
packages/api/src/router/widgets/downloads.ts 35.64% 100% 100% 35.64% 23-39, 44-65, 70-75, 81-86, 91-96, 102-107, 113-118
packages/api/src/router/widgets/indexer-manager.ts 29.31% 100% 100% 29.31% 21-32, 38-55, 60-71
packages/api/src/router/widgets/media-requests.ts 21.5% 100% 100% 21.5% 17-39, 44-65, 70-91, 97-106
packages/api/src/router/widgets/smart-home.ts 53.19% 100% 100% 53.19% 20-22, 28-42, 48-54, 60-61
packages/integrations/src/index.ts 100% 100% 100% 100%
packages/integrations/src/types.ts 100% 100% 100% 100%
packages/integrations/src/base/creator.ts 54% 100% 0% 54% 31-47, 50-61
packages/integrations/src/base/error.ts 71.42% 80% 80% 71.42% 7-15, 31-32
packages/integrations/src/base/session-store.ts 13.63% 100% 0% 13.63% 8-27
packages/integrations/src/interfaces/dns-hole-summary/dns-hole-summary-integration.ts 0% 0% 0% 0%
packages/integrations/src/pi-hole/pi-hole-integration-factory.ts 20% 100% 0% 20% 8-22
packages/integrations/src/pi-hole/v6/pi-hole-integration-v6.ts 81.25% 62.06% 100% 81.25% 38-39, 44-45, 60-61, 67-68, 92-93, 99-100, 115-116, 131-132, 144-151, 175-176, 199-200
packages/integrations/src/pi-hole/v6/pi-hole-schemas-v6.ts 100% 33.33% 100% 100%
packages/redis/src/index.ts 100% 100% 100% 100%
packages/redis/src/lib/channel.ts 21.48% 100% 13.79% 21.48% 28-38, 44-48, 50-52, 71-73, 79-80, 85-86, 92-93, 102-125, 142-151, 158-184, 189-190, 196-197, 202-204, 207-214, 217-224, 227-228, 231-289, 292-313, 327-329, 331-332, 340-343, 354-356, 363-365, 371-373, 378-379
packages/request-handler/src/calendar.ts 58.33% 100% 0% 58.33% 15-19
packages/request-handler/src/dns-hole.ts 70% 100% 0% 70% 15-17
packages/request-handler/src/downloads.ts 70% 100% 0% 70% 15-17
packages/request-handler/src/health-monitoring.ts 68.42% 100% 0% 68.42% 15-17, 28-30
packages/request-handler/src/indexer-manager.ts 70% 100% 0% 70% 15-17
packages/request-handler/src/media-request-list.ts 70% 100% 0% 70% 15-17
packages/request-handler/src/media-request-stats.ts 53.84% 100% 0% 53.84% 15-20
packages/request-handler/src/media-server.ts 70% 100% 0% 70% 15-17
packages/request-handler/src/media-transcoding.ts 50% 100% 0% 50% 17-23
packages/request-handler/src/smart-home-entity-state.ts 50% 100% 0% 50% 14-22
Generated in workflow #5357 for commit 0d939c2 by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf removed the blocked Blocked by something external / internal label Feb 28, 2025
@Meierschlumpf Meierschlumpf marked this pull request as ready for review February 28, 2025 17:48
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner February 28, 2025 17:48
@Meierschlumpf Meierschlumpf merged commit 3804d53 into dev Mar 4, 2025
13 checks passed
@Meierschlumpf Meierschlumpf deleted the pihole-v6 branch March 4, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: upgrade pi-hole integration to v6
2 participants