Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integration): store omv session in redis #2467

Merged
merged 5 commits into from
Mar 4, 2025
Merged

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm build, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

First #2448 should be merged

Closes #1905

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Mar 1, 2025
@Meierschlumpf Meierschlumpf self-assigned this Mar 1, 2025
Copy link

deepsource-io bot commented Mar 1, 2025

Here's the code health analysis summary for commits 3804d53..24d5867. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Mar 1, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 23.29% 9890 / 42453
🔵 Statements 23.29% 9890 / 42453
🔵 Functions 30.08% 414 / 1376
🔵 Branches 65.09% 1184 / 1819
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/integrations/src/base/session-store.ts 9.67% 100% 0% 9.67% 10-38
packages/integrations/src/openmediavault/openmediavault-integration.ts 1.87% 100% 0% 1.87% 22-210
packages/integrations/src/pi-hole/v6/pi-hole-integration-v6.ts 74.3% 59.25% 90.9% 74.3% 38-39, 44-45, 60-61, 67-68, 89, 92-93, 99-100, 115-116, 131-132, 144-151, 175-176, 191-203
Generated in workflow #5378 for commit 24d5867 by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf marked this pull request as ready for review March 2, 2025 09:01
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner March 2, 2025 09:01
@Meierschlumpf Meierschlumpf marked this pull request as draft March 2, 2025 09:01
Base automatically changed from pihole-v6 to dev March 4, 2025 20:17
@Meierschlumpf Meierschlumpf marked this pull request as ready for review March 4, 2025 20:32
@Meierschlumpf Meierschlumpf requested a review from manuel-rw March 4, 2025 20:38
@manuel-rw manuel-rw merged commit b3e4f30 into dev Mar 4, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Email gets flooded with health check for OMV
2 participants