Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .removeable and enforce it removeWriter #166

Merged
merged 2 commits into from
Jul 29, 2024
Merged

add .removeable and enforce it removeWriter #166

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8b71b3
add .removeable and enforce it removeWriter
mafintosh Jul 29, 2024
9f8b2e2
test removeWriter throwing
mafintosh Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1873,9 +1873,19 @@ module.exports = class Autobase extends ReadyResource {
this._queueBump()
}

removeable (key) {
if (this.system.indexers.length !== 1) return true
return !b4a.equals(this.system.indexers[0].key, key)
}

// triggered from apply
async removeWriter (key) { // just compat for old version
assert(this._applying !== null, 'System changes are only allowed in apply')

if (!this.removeable(key)) {
throw new Error('Not allowed to remove the last indexer')
}

await this.system.remove(key)

if (b4a.equals(key, this.local.key)) {
Expand Down
Loading