Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .removeable and enforce it removeWriter #166

Merged
merged 2 commits into from
Jul 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -1873,9 +1873,19 @@ module.exports = class Autobase extends ReadyResource {
this._queueBump()
}

removeable (key) {
if (this.system.indexers.length !== 1) return true
return !b4a.equals(this.system.indexers[0].key, key)
}

// triggered from apply
async removeWriter (key) { // just compat for old version
assert(this._applying !== null, 'System changes are only allowed in apply')

if (!this.removeable(key)) {
throw new Error('Not allowed to remove the last indexer')
}

await this.system.remove(key)

if (b4a.equals(key, this.local.key)) {
Expand Down
19 changes: 4 additions & 15 deletions test/basic.js
Original file line number Diff line number Diff line change
Expand Up @@ -1362,7 +1362,9 @@ test('basic - indexer removes themselves', async t => {
}
})

test('basic - all indexers removed', async t => {
test('basic - cannot remove last indexer', async t => {
t.plan(7)

const { bases } = await create(2, t, { apply })
const [a, b] = bases

Expand All @@ -1381,19 +1383,6 @@ test('basic - all indexers removed', async t => {

await a.append({ remove: b4a.toString(a.local.key, 'hex') })

await replicateAndSync([a, b])

t.is(a.writable, false)

t.is(a.view.getBackingCore().session.manifest.signers.length, 0)
t.is(b.view.getBackingCore().session.manifest.signers.length, 0)

t.is(a.view.length, 1)
t.is(b.view.length, 1)

await t.exception(a.append('fail'), /Not writable/)
await t.exception(b.append('fail'), /Not writable/)

async function apply (batch, view, base) {
for (const { value } of batch) {
if (value.add) {
Expand All @@ -1402,7 +1391,7 @@ test('basic - all indexers removed', async t => {
}

if (value.remove) {
await base.removeWriter(b4a.from(value.remove, 'hex'))
await t.exception(() => base.removeWriter(b4a.from(value.remove, 'hex')))
continue
}

Expand Down
Loading