Add disjointness reasoning for BbML #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPTK
reviewed
Jan 13, 2025
LPTK
reviewed
Jan 13, 2025
LPTK
reviewed
Jan 13, 2025
LPTK
reviewed
Jan 13, 2025
|
BTW, since you are modifying the way forall types are printed. Why not print them like in the source? Eg |
LPTK
reviewed
Jan 14, 2025
LPTK
reviewed
Jan 21, 2025
|
|
||
| fun f: ([A] -> ([B] -> A | B -> B | A) -> A) -> ([A] -> ([B] -> A | B -> B | A) -> A) | ||
| f | ||
| //│ Type: (['A] -> (['B] -> ('A ∨ 'B) ->{⊥} 'B ∨ 'A) ->{⊥} 'A) ->{⊥} ['A] -> (['B] -> ('A ∨ 'B) ->{⊥} 'B ∨ 'A) ->{⊥} 'A |
There was a problem hiding this comment.
Can we please use | and & rather than ∨ and ∧?
There was a problem hiding this comment.
This can be done in a future PR, though.
Comment on lines
+98
to
+100
| val state = new VarState() | ||
| state.upperBounds = ctx.getRegEnv :: Nil | ||
| state.lowerBounds = ctx.getRegEnv :: Nil |
There was a problem hiding this comment.
I wonder what's the point of creating a new TV that's equivalent to an underlying type ctx.getRegEnv. I see freshEnv is only used in instantiate. Why can't instantiate substitute simple types for variables? Instead of just variables for variables?
LPTK
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
outervariables forfunctionspolymorphic typesThis PR is still being prepared, e.g., containing redundant code. Such problems will be addressed after the main problems are discussed in the meeting.