Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New MLscript frontend #187

Merged
merged 533 commits into from
Jan 12, 2024
Merged

New MLscript frontend #187

merged 533 commits into from
Jan 12, 2024

Conversation

LPTK
Copy link
Contributor

@LPTK LPTK commented Oct 4, 2023 •
edited
Loading

This implements the new parsing and type checking of MLscript definitions, moving it further towards a complete and usable general-purpose programming language with support for blended FP/OOP.

It's still a work in progress and several pieces are still missing. For example:

  • self-type signatures are not yet checked
  • variance analysis is currently extremely limited and needs to be redone
  • variance annotations are not checked!
  • many indirectly-referential methods and other definitions fail to compile when they should, emitting spurious cycle dependency errors
  • we do not currently allow a definition to refer to a non-top-level type defined in an enclosing scope
  • the handling of unknown type argument ranges (bounded wildcards) is missing; currently we display to users types that are kind of wrong because they wrongly use internal type ranges
  • this-matching doesn’t really work due to spurious cyclic typing errors
  • accessing fields in parent specifications doesn’t really work due to spurious cyclic parent-spec-typing errors

We are also sorely missing user-facing documentation.

chengluyu and others added 30 commits May 5, 2023 15:00
@chengluyu
Merge branch 'new-definition-typing' into ucs-paper
ee1ab19
@Meowcolm024
add tests for inheritance
7a6d03c
@NeilKleistGao
Add abstract keyword
fabe0d3
@NeilKleistGao
Add :e for the rejected test case
d335b3f
@NeilKleistGao
WIP: Try to fix new keyword generation in backend
bad4013
@NeilKleistGao
WIP: Update test cases
cd2a52d
@NeilKleistGao
WIP: Undo changes for abstract
9734d91
@NeilKleistGao
WIP: Try to add abstract and optional parameters(not ready)
f4328ae
@NeilKleistGao
WIP: Freeze object before returning(not ready)
eea3c1e
@LPTK
Fix freshening of type definitions/methods and do not generalize meth…
75d1470 
…od types unless annotated
@Meowcolm024
FIXED type members of parent trait
9cda253
@NeilKleistGao
WIP: Support extend and pattern matching(not ready)
b2c5592
@LPTK
WIP Add a test
2d35696
@NeilKleistGao
WIP: Refactor code
e11001b
@NeilKleistGao
WIP: Force new in new NuTypeSym
84a30f0
@NeilKleistGao
WIP: Fix New generation
176f7ce
@chengluyu
Fix comments
66d41f2
@NeilKleistGao
WIP: Rename field and generate .class in new
8694f1c
@NeilKleistGao
WIP: Change NuTypeDef
f8c603a
@NeilKleistGao
WIP: Add assignment for constructor and move constructor outside the …
37481e7 
…modifier
@LPTK
Update CI: run on all PRs
34b1864
@Meowcolm024
clean up
a098242
@NeilKleistGao
WIP: Generate overrided constructor
374f7c0
@Meowcolm024
fix trait error msg
6531044
@Meowcolm024
small cleanup
bd49339
@NeilKleistGao
Check constructor in mixin and module, fix spelling and improve code
002615d
@NeilKleistGao
Remove comment
0781e3e
@chengluyu
Fix minor problems mentioned in PR comments
70fd442
@chengluyu
Fix the warning in UCS source files
b89fa16
@chengluyu
Try to fix more warnings
14a232a
@LPTK LPTK linked an issue Oct 11, 2023 that may be closed by this pull request
Implement new MLscript syntax #120
Closed
@LPTK LPTK mentioned this pull request Oct 11, 2023
Closed
@LPTK LPTK linked an issue Oct 11, 2023 that may be closed by this pull request
Recover parametricity using a matchable top type #94
Closed
LPTK and others added 8 commits October 12, 2023 14:53
@LPTK LPTK force-pushed the new-definition-typing branch from 550a322 to 8894b74 Compare November 22, 2023 17:16
LPTK and others added 16 commits November 23, 2023 01:16
@LPTK
Fix corner case parsing bug
8ab9346
@LPTK
Overhaul support for new operator
2a3a104 
Fixes #191
The current lifter implementation is buggy and its results changed strangely
@LPTK
Clean up some tests + add some doc
b8db6a1
@NeilKleistGao
Fix codegen error for global functions (#186)
4909975
@chengluyu
Add a potentially buggy test case
b11b9cb
@LPTK
Update SBT version
231d9ec
@chengluyu
Support integer literals of different radices and decimal numeric lit…
f121cd0 
…erals (#199)

* Support hex, octal, and binary integers

* Support seperators in integer literals

* Support decimal numbers
@chengluyu
Fix name duplication in code generation for new definition typing (#197)
0049da9
@chengluyu
Remove inspection function for syntax tree nodes (#200)
29e38d1
@chengluyu
Fix code generation for local functions declared by let rec (#198)
1a7463e
@LPTK
Merge branch 'mlscript' into new-definition-typing
a36092e
@LPTK
Update NodeTest
e362241
@LPTK
Introduce comma operator and use ,/; instead of ;/;; (#204)
a68e1de
@LPTK
Fix/virtual type arg params (#205)
cc2773d
@LPTK
Allow somewhat flat if-then-else expressions
0e5e01b
@LPTK
Improve self-type handling (#206)
05752ff 
* Fix self-type-blindness
* Make ctor signatures produce typerefs
* Add explicit variance annotations (variance analysis needs to be overhauled)
* Warn when annotating concrete classes
* Handle transitively-inherited self-types properly
* Fix generic modules (somewhat)
* Fix transitively-inherited trait signatures
* Fix SOF in type simplifier due to cyclic self-types
@LPTK LPTK merged commit 4511944 into mlscript Jan 12, 2024
1 check passed
@LPTK LPTK mentioned this pull request Feb 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement new MLscript syntax Recover parametricity using a matchable top type
7 participants
@LPTK @chengluyu @Meowcolm024 @NeilKleistGao @andongfan @mbroughani81 @HarrisL2