Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coil forces #450

Merged
merged 84 commits into from
Oct 20, 2024
Merged

Coil forces #450

merged 84 commits into from
Oct 20, 2024

Conversation

smhurwitz
Copy link
Contributor

This is to pull all the force optimization work into master.

phuslage and others added 30 commits June 14, 2023 12:47
Update branch to have FramedCurve for coil orientation
:wq
…rently working, but the autodifferentiation and VJPs still all need to be implemented for dJ.
	modified:   src/simsopt/field/force_2.py
…hout Exceptions in the commit. Additionally, a Taylor test has been coded up, though it is currently failing. Next step is to see what is wrong with either the test or the Optimizable (presumably the Optimizable).
@landreman
Copy link
Contributor

In selffield.py, the functions G, K, local_field, local_field_rect, field_from_other_coils, and field_from_other_coils_pure are not used in any test or example. Codecov is flagging these functions for having no test coverage. The function local_field_rect would need some work anyway to use a general frame instead of the Frenet frame, and both local_field_rect, field_from_other_coils should be vectorized to avoid the explicit for loop. So, I propose we remove these functions for now from the PR, since getting these functions polished and tested would delay the merge of the functions for Lorentz force, and they can be merged in a separate PR later. If anyone objects, let me know.

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 99.32432% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.68%. Comparing base (988e15c) to head (27f3959).
Report is 85 commits behind head on master.

Files with missing lines Patch % Lines
src/simsopt/geo/curve.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
+ Coverage   92.61%   92.68%   +0.06%     
==========================================
  Files          75       77       +2     
  Lines       13837    13982     +145     
==========================================
+ Hits        12815    12959     +144     
- Misses       1022     1023       +1     
Flag Coverage Δ
unittests 92.68% <99.32%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@landreman
Copy link
Contributor

Hearing no objections, I'll merge.

@landreman landreman merged commit 90ac595 into master Oct 20, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants