-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore *.out to .gitignore, except in resources #14796
Open
patrick-schultz
wants to merge
2
commits into
main
Choose a base branch
from
ps/gitignore
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 21, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
cjllanwarne
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this should solve the problem!
chrisvittal
approved these changes
Jan 21, 2025
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
from
January 21, 2025 21:02
b4c7447
to
93620ef
Compare
patrick-schultz
force-pushed
the
ps/gitignore
branch
from
January 21, 2025 21:02
6ba3658
to
d4a6a03
Compare
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
from
January 22, 2025 17:04
93620ef
to
e0b9c06
Compare
patrick-schultz
force-pushed
the
ps/gitignore
branch
from
January 22, 2025 17:04
d4a6a03
to
be0a89c
Compare
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
from
January 22, 2025 17:49
e0b9c06
to
468844b
Compare
patrick-schultz
force-pushed
the
ps/gitignore
branch
from
January 22, 2025 17:49
be0a89c
to
380493e
Compare
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
from
January 22, 2025 19:50
468844b
to
fcb6c23
Compare
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
from
January 24, 2025 19:24
fcb6c23
to
b9fe4aa
Compare
patrick-schultz
force-pushed
the
ps/gitignore
branch
from
January 24, 2025 19:24
380493e
to
e50929b
Compare
Base automatically changed from
ps-12-17-move_mill_modules_into_subdirectory
to
main
January 24, 2025 20:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Restore *.out to .gitignore, with an exclusion in resource directories
Security Assessment
Delete all except the correct answer:
Impact Description
Only changes gitignore rules
(Reviewers: please confirm the security impact before approving)