Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] codegen all value ir node classes #14771

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

patrick-schultz
Copy link
Collaborator

Change Description

Fixes #<issue_number> (delete if N/A)

Brief description and justification of what this PR is doing.

Security Assessment

Delete all except the correct answer:

  • This change has a high security impact
    • Required: The impact has been assessed and approved by appsec
  • This change has a medium security impact
  • This change has a low security impact
  • This change has no security impact

Impact Description

For none/low impact: a quick one/two sentence justification of the rating.

  • Example: "Docs only", "Low-level refactoring of non-security code", etc.
    For medium/high impact: provide a description of the impact and the mitigations in place.
  • Example: "New UI text field added in analogy to existing elements, with input strings escaped and validated against code injection"

(Reviewers: please confirm the security impact before approving)

Copy link
Collaborator Author

patrick-schultz commented Dec 17, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@patrick-schultz patrick-schultz mentioned this pull request Dec 17, 2024
@patrick-schultz patrick-schultz force-pushed the ps-12-16-mill_update branch 2 times, most recently from dcc28c1 to 728ff17 Compare December 17, 2024 18:24
@patrick-schultz patrick-schultz changed the base branch from ps-12-16-mill_update to ps-12-17-move_mill_modules_into_subdirectory December 17, 2024 19:22
@patrick-schultz patrick-schultz force-pushed the ps-12-17-move_mill_modules_into_subdirectory branch from ab6e982 to f7dac2a Compare December 17, 2024 20:09
@patrick-schultz patrick-schultz force-pushed the ps-12-17-move_mill_modules_into_subdirectory branch from f7dac2a to 6c275c2 Compare December 17, 2024 20:37
@patrick-schultz patrick-schultz force-pushed the ps-12-17-move_mill_modules_into_subdirectory branch from 6c275c2 to c291b9c Compare December 18, 2024 12:22
@ehigham ehigham force-pushed the ps-12-17-move_mill_modules_into_subdirectory branch from c291b9c to 1147b2b Compare December 18, 2024 15:53
@patrick-schultz patrick-schultz force-pushed the ps-12-17-move_mill_modules_into_subdirectory branch from 1147b2b to c291b9c Compare December 18, 2024 16:05
@patrick-schultz patrick-schultz changed the base branch from ps-12-17-move_mill_modules_into_subdirectory to ehigham/memory-mill-module December 18, 2024 16:06
@patrick-schultz patrick-schultz force-pushed the ehigham/memory-mill-module branch from 2e1deb3 to 3b20487 Compare December 18, 2024 17:45
@ehigham ehigham force-pushed the ehigham/memory-mill-module branch from 3b20487 to 0b47eab Compare December 18, 2024 18:19
@patrick-schultz patrick-schultz force-pushed the ehigham/memory-mill-module branch from 0b47eab to edc5067 Compare December 18, 2024 18:32
@patrick-schultz patrick-schultz force-pushed the ehigham/memory-mill-module branch from edc5067 to 0463555 Compare December 18, 2024 19:30
@patrick-schultz patrick-schultz changed the base branch from ehigham/memory-mill-module to ps-12-17-move_mill_modules_into_subdirectory January 2, 2025 18:42
@patrick-schultz patrick-schultz force-pushed the ps-12-17-move_mill_modules_into_subdirectory branch 4 times, most recently from 6ce5016 to e793b6d Compare January 3, 2025 15:59
@patrick-schultz patrick-schultz force-pushed the ps-12-17-move_mill_modules_into_subdirectory branch from e793b6d to 99d285e Compare January 3, 2025 18:10
@patrick-schultz patrick-schultz force-pushed the ps-12-17-move_mill_modules_into_subdirectory branch from 99d285e to c066895 Compare January 3, 2025 19:51
@patrick-schultz patrick-schultz force-pushed the ps-12-17-move_mill_modules_into_subdirectory branch from c066895 to 0cbe834 Compare January 7, 2025 13:54
@patrick-schultz patrick-schultz force-pushed the ps-12-17-move_mill_modules_into_subdirectory branch from 0cbe834 to 744963b Compare January 7, 2025 17:14
@patrick-schultz patrick-schultz force-pushed the ps-12-17-move_mill_modules_into_subdirectory branch from 744963b to c54210d Compare January 9, 2025 17:08
@patrick-schultz patrick-schultz force-pushed the ps-12-17-move_mill_modules_into_subdirectory branch from c54210d to e2bdc83 Compare January 9, 2025 19:59
@patrick-schultz patrick-schultz changed the title ir gen mvp [query] codegen all value ir node classes Jan 9, 2025
@patrick-schultz patrick-schultz changed the base branch from ps-12-17-move_mill_modules_into_subdirectory to main January 9, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant