Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nix): Bump dependencies. #219

Merged
merged 3 commits into from
Jan 13, 2022
Merged

chore(nix): Bump dependencies. #219

merged 3 commits into from
Jan 13, 2022

Conversation

dhess
Copy link
Member

@dhess dhess commented Jan 13, 2022

This should fix the issue we were having with intermittently failing
builds due to a nix-darwin issue.

It also fixes the issue we were seeing where entering the nix develop
shell was updating flake.lock, which is related.

This should fix the issue we were having with intermittently failing
builds due to a nix-darwin issue.
@dhess
Copy link
Member Author

dhess commented Jan 13, 2022

The first build of this PR failed with strange errors like this one:

https://buildkite.com/hackworthltd/primer/builds/19#54ea18c1-b7b0-4558-9d81-dee1289dd067

/nix/store/sw5yg99apcanb4fdcza1pz98i2av9dp6-primer-test-primer-test-0.7.0.0.drv
--
  | don't know how to build these paths:
  | /nix/store/sw5yg99apcanb4fdcza1pz98i2av9dp6-primer-test-primer-test-0.7.0.0.drv
  | error: cannot build missing derivation '/nix/store/sw5yg99apcanb4fdcza1pz98i2av9dp6-primer-test-primer-test-0.7.0.0.drv'
  | 🚨 Error: The command exited with status 1

FYI, that happened because the build took awhile, and between the step where the Buildkite plugin built the derivations (.drv files) for each package in the build and the step(s) where those .drv files were finally used, the garbage collector ran and deleted those .drv files from the Nix store! This is a known issue with the Nix Buildkite plugin: circuithub/nix-buildkite-buildkite-plugin#1

This is the first time this has happened to us, but it probably won't be the last. I will set the GC to run less often: the builder has plenty of space and can probably run for at least a month before we need to GC. However, longer term we'll want to figure out a better solution to this.

dhess added 2 commits January 13, 2022 09:42
No functional changes here, this is pure formatting.

Note that we exclude `primer/test/outputs` as those are
formatting-sensitive.
@dhess dhess merged commit 996e3a6 into main Jan 13, 2022
@dhess dhess deleted the dhess/bump-deps branch January 13, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant