Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fbconnect.js to use async #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

RGHuhn
Copy link

@RGHuhn RGHuhn commented May 8, 2019

avoiding blocking critical request path re:https://developers.google.com/web/tools/lighthouse/audits/critical-request-chains?utm_source=lighthouse&utm_medium=unknown

Submitting Pull Requests

General

  • Make sure you use semantic commit messages.
    Examples: "fix(google): Fixed foobar bug", "feat(accounts): Added foobar feature".
  • All Python code must be 100% pep8 and isort clean.
  • JavaScript code should adhere to StandardJS.
  • If your changes are significant, please update ChangeLog.rst.
  • Feel free to add yourself to AUTHORS.

Provider Specifics

In case you add a new provider:

  • Make sure unit tests are available.
  • Add an entry of your provider in test_settings.py::INSTALLED_APPS and docs/installation.rst::INSTALLED_APPS.
  • Add documentation to docs/providers.rst.
  • Add an entry to the list of supported providers over at docs/overview.rst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants