Removed 2 sql queries, prevented race condition

groveco · Apr 22, 2020 · f5d9d4b · f5d9d4b
1 parent b52a61b
commit f5d9d4b
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/allauth/account/utils.py b/allauth/account/utils.py
@@ -359,10 +359,14 @@ def sync_user_email_addresses(user):
                 and EmailAddress.objects.filter(email__iexact=email).exists():
             # Bail out
             return
-        EmailAddress.objects.create(user=user,
-                                    email=email,
-                                    primary=False,
-                                    verified=False)
+        EmailAddress.objects.get_or_create(
+            user=user,
+            email=email,
+            defaults={
+                'primary': False,
+                'verified': False
+            }
+        )
 
 
 def filter_users_by_username(*username):