use fresher node and debian version #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves to node 22 and debian bookworm, since the versions we've been building and testing with are getting old. There is some old material kept around for (speaks very quietly) Python 2 (looks around hoping no-one heard) which we continue to support for some long-time users but really really should drop soon.
georgegevoian
approved these changes
Oct 10, 2024
|
For the Importer failure, I think it might need a |
Thanks I'll try. I disrupted things when, running the tests locally, I needed to set them in light mode since colors are checked literally :( |
Yeah, I've been bit by that before too. Could do with a hook before browser tests are run that disables syncing with OS in preferences. |
… and cannot replicate locally
georgegevoian
approved these changes
Oct 10, 2024
paulfitz
added a commit
that referenced
this pull request
Oct 12, 2024
This partially undos a recent upgrade because it results in `gvisor` sandboxing not functioning. Hopefully this is temporary, to give time to track down the cause, fix it, and extend CI testing on candidate docker images to include `gvisor` sandboxing. Upgrade: #1255 Sorry for the breakage!
paulfitz
added a commit
that referenced
this pull request
Oct 12, 2024
This partially undos a recent upgrade because it results in `gvisor` sandboxing not functioning. Hopefully this is temporary, to give time to track down the cause, fix it, and extend CI testing on candidate docker images to include `gvisor` sandboxing. Upgrade: #1255 Sorry for the breakage!
paulfitz
added a commit
that referenced
this pull request
Nov 18, 2024
This returns to an upgrade first attempted in: #1255 That upgrade ran into sandbox trouble, which eventually proved to be a small change in the layout of directories in bookworm relative to buster (`/lib64` became a symlink).
paulfitz
added a commit
that referenced
this pull request
Nov 18, 2024
This returns to an upgrade first attempted in: #1255 That upgrade ran into sandbox trouble, which eventually proved to be a small change in the layout of directories in bookworm relative to buster (`/lib64` became a symlink).
paulfitz
added a commit
that referenced
this pull request
Nov 19, 2024
This returns to an upgrade first attempted in: #1255 That upgrade ran into sandbox trouble, which eventually proved to be a small change in the layout of directories in bookworm relative to buster (`/lib64` became a symlink).
hexaltation
added a commit
to hexaltation/grist-core
that referenced
this pull request
Jan 7, 2025
4 tasks
paulfitz
pushed a commit
that referenced
this pull request
Jan 7, 2025
## Context In #1255 node version was updated to node 22 in CI. In #1311 node version was updated to node 22 in `dockerfile` It seems a good idea to upgrade `.nvmrc` to such node version too. ## Proposed solution Update of value in `.nvmrc` ## Has this been tested? - [ ] 👍 yes, I added tests to the test suite - [ ] 💭 no, because this PR is a draft and still needs work - [X] 🙅 no, because this is not relevant here - [ ] 🙋 no, because I need help <!-- Detail how we can help you -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This moves to node 22 and debian bookworm, since the versions we've been building and testing with are getting old.
There is some old material kept around for (speaks very quietly) Python 2 (looks around hoping no-one heard) which we continue to support for some long-time users but really really should drop soon.
Has this been tested?
Existing tests should pass before this lands. I did spot checks locally. I tested the docker build locally for Python3 and Python2.
The changes for the node upgrade were all test related. I did them in a way that shouldn't impair running on older versions of node, and did spot checks for this. This is to give some breathing room for upgrading Grist Lab's grist-saas as follow up work.