Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move docker image back to node 18 / buster #1260

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Conversation

paulfitz
Copy link
Member

@paulfitz paulfitz commented Oct 12, 2024

This partially undos a recent upgrade because it results in gvisor sandboxing not functioning. Hopefully this is temporary, to give time to track down the cause, fix it, and extend CI testing on candidate docker images to include gvisor sandboxing.

Upgrade: #1255

Sorry for the breakage! Workarounds until this lands and takes effect: use the gristlabs/grist:stable image, or set GRIST_SANDBOX_FLAVOR to pyodide.

Tested manually with:

docker build -t candidate .
mkdir -p /tmp/candidate
docker run -e GRIST_SANDBOX_FLAVOR=gvisor -v /tmp/candidate:/persist \
  --name /grist --rm -p 8484:8484 -it candidate

and checking whether formulas work, before and after the change.

This partially undos a recent upgrade because it results in
`gvisor` sandboxing not functioning. Hopefully this is temporary,
to give time to track down the cause, fix it, and extend CI testing
on candidate docker images to include `gvisor` sandboxing.

Upgrade: #1255

Sorry for the breakage!
@paulfitz paulfitz marked this pull request as ready for review October 12, 2024 02:10
@georgegevoian georgegevoian self-requested a review October 12, 2024 02:12
@paulfitz paulfitz merged commit 3246842 into main Oct 12, 2024
11 checks passed
@paulfitz paulfitz deleted the paulfitz/docker-revert branch October 12, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants