Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feed sync #389
Feed sync #389
Changes from 14 commits
b3624a8
174cbbe
0d3e0fb
54be934
83f0537
96067ed
7d8328d
b9dfbb0
fa4d930
c2ff178
2037c37
40b32db
3460fa7
eab20f8
9c3147c
f69a664
ef2bce6
d917c70
d1fed1f
a389619
a87698e
e0251ba
414643f
e539d81
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can lead to mistakes because installing the
grenbone-feed-sync
python project will also installgreenbone-certdata-sync
,greenbone-scapdata-sync
andgreenbone-nvt-sync
scripts that just use the newgreenbone-feed-sync
script with the desired type of feed. The only clear difference is that the old scripts are installed into an sbin directory and the new ones will be put into a bin directory.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have modified this in the new commit which I will push later today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK the old script is always installed into sbin via gvmd's make file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have modified this in the new commit which I will push later today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JFYI: the
feed-type
argument doesn't care for lower or upper case letters.SCAP_DATA
is the same asscap_data
or evenScAp_DaTa
.