Feed sync #389
Feed sync #389
Conversation
Fixing the commands that create Redis configuration files for systemd to execute the entire command as sudo privs.
…temd-commands Update redis.md
This command to install dependencies leaves out sudo
Update dependencies.md
Fix command to install dependencies missing sudo
Update dependencies.md
The first version of a comprehensive feed synchronization documentation.
The first draft of a comprehensive Greenbone feed sync instruction manual
updates for clarity
Added logo
Small additions
|
Hey, just submitting the comprehensive |
syspect-sec
had a problem deploying
to
github-pages
GitHub Actions
Failure
src/feed-sync.md
Outdated
| - `/usr/local/sbin/greenbone-feed-sync` or `/usr/sbin/greenbone-feed-sync`: This is the old sync script written in bash to download CERT, SCAP, and GVMD_DATA. It is no longer installed by default since gvmd 22.5.0. | ||
|
|
||
| ### Deprecated Sync Script Removal | ||
| If you have any of the deprecated sync scripts (`greenbone-certdata-sync`, `greenbone-scapdata-sync`, `greenbone-nvt-sync`, `/usr/local/sbin/greenbone-feed-sync` or `/usr/sbin/greenbone-feed-sync`) installed, it is recommended to remove them. This step ensures a clean transition to the new sync script. |
There was a problem hiding this comment.
This can lead to mistakes because installing the grenbone-feed-sync python project will also install greenbone-certdata-sync, greenbone-scapdata-sync and greenbone-nvt-sync scripts that just use the new greenbone-feed-sync script with the desired type of feed. The only clear difference is that the old scripts are installed into an sbin directory and the new ones will be put into a bin directory.
There was a problem hiding this comment.
I have modified this in the new commit which I will push later today.
src/feed-sync.md
Outdated
| ``` | ||
| ```sh | ||
| # If the legacy bash feed update script is active you will see | ||
| head -1 /usr/local/bin/greenbone-feed-sync |
There was a problem hiding this comment.
AFAIK the old script is always installed into sbin via gvmd's make file.
There was a problem hiding this comment.
I have modified this in the new commit which I will push later today.
Co-authored-by: Björn Ricks <[email protected]>
Head branch was pushed to by a user without write access
Co-authored-by: Björn Ricks <[email protected]>
Co-authored-by: Björn Ricks <[email protected]>
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Co-authored-by: Björn Ricks <[email protected]>
Head branch was pushed to by a user without write access
Co-authored-by: Björn Ricks <[email protected]>
Head branch was pushed to by a user without write access
Co-authored-by: Björn Ricks <[email protected]>
Co-authored-by: Björn Ricks <[email protected]>
Head branch was pushed to by a user without write access
Co-authored-by: Björn Ricks <[email protected]>
Head branch was pushed to by a user without write access
|
I did my best to navigate this PR with comments. I am not very fluent in reviewing GitHub PR since I mostly manage my own repositories solo and don't have to merge with other developers. I'll do my best to manage it properly, but it will take some learning curve for me. Sorry for any mistakes with the GitHub process. |
Head branch was pushed to by a user without write access
syspect-sec
had a problem deploying
to
github-pages
GitHub Actions
Failure
Pull request was closed
What
Adding the file
feed-sync.mdto the src main directory and adding thefeed-syncto the TOC in the mainindex.mdfileWhy
To provide additional documentation to support GB CE portal.