Upgrade experimental module (deps): Bump github.com/grafana/xk6-browser from 1.3.0 to 1.4.1 #3625
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
requested review from
mstoykov,
oleiade and
a team
and removed request for
a team
go.mod
Outdated
| @@ -36,7 +36,7 @@ require ( | |||
| github.com/spf13/afero v1.1.2 | |||
| github.com/spf13/cobra v1.4.0 | |||
| github.com/spf13/pflag v1.0.5 | |||
| github.com/stretchr/testify v1.8.4 | |||
| github.com/stretchr/testify v1.9.0 | |||
There was a problem hiding this comment.
Can you fix this @grafana/k6-browser unless you need some new functionality in it
There was a problem hiding this comment.
No, we don't need the new functionality, but if it doesn't break the k6-core functionality, is there any harm in upgrading it? It's only used for tests.
There was a problem hiding this comment.
Is there a strong aversion to this upgrade?
There was a problem hiding this comment.
I do prefer that you release .1 release with reverting this and make certain you don't just bump dependencies without need in the future.
While this is not strictly necessary for the code - so is all the linting and formatting we do. I would prefer not to have to make exceptions for cases where there is no need.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3625 +/- ##
==========================================
- Coverage 73.59% 73.57% -0.02%
==========================================
Files 277 277
Lines 20244 20244
==========================================
- Hits 14898 14895 -3
- Misses 4398 4401 +3
Partials 948 948
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Bumps [github.com/grafana/xk6-browser](https://github.com/grafana/xk6-browser) from 1.3.0 to 1.4.0. - [Release notes](https://github.com/grafana/xk6-browser/releases) - [Commits](grafana/xk6-browser@v1.3.0...v1.4.0) --- updated-dependencies: - dependency-name: github.com/grafana/xk6-browser dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/grafana/xk6-browser-1.4.0
branch
from
7e8b47b to
934fe2b
Compare
ankur22
changed the title
|
A newer version of github.com/grafana/xk6-browser exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
mstoykov
deleted the
dependabot/go_modules/github.com/grafana/xk6-browser-1.4.0
branch
Bumps github.com/grafana/xk6-browser from 1.3.0 to 1.4.1.
Release notes
Sourced from github.com/grafana/xk6-browser's releases.
Commits
a055418Fix ElementHandle.setInputFiles8326296Add tests for setInputFiles() in the injected scriptcd35c13Add tests for SetInputFiles functionality in ElementHandle027d0bfAdd test for SetInputFiles functionb7010aaAdd SetInputFiles functionality to Page and Frame273240bRefactor: separate SetInputFiles parameter from optionsd9d2009Add capability to set input files in multiple form38c1a6bAdd setInputFiles to ElementHandle93edd08Add testRunId to the k6 object3bbd316Add opts to startIterationDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)