Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to browser@fcc7f9e5f4 #3621

Closed
wants to merge 1 commit into from
Closed

Update to browser@fcc7f9e5f4 #3621

wants to merge 1 commit into from

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Mar 4, 2024

What?

Updates k6-core for the v0.50 canary release.

Just putting it here to make a release.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

@inancgumus inancgumus requested a review from a team as a code owner March 4, 2024 08:55
@inancgumus inancgumus requested review from mstoykov and oleiade and removed request for a team March 4, 2024 08:55
For the v0.50 canary release.
mstoykov
mstoykov previously approved these changes Mar 4, 2024
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the golangci-lint bump

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.58%. Comparing base (47c5bb0) to head (44c9412).

❗ Current head 44c9412 differs from pull request most recent head 78a0ee3. Consider uploading reports for the commit 78a0ee3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3621   +/-   ##
=======================================
  Coverage   73.57%   73.58%           
=======================================
  Files         277      277           
  Lines       20244    20244           
=======================================
+ Hits        14895    14897    +2     
+ Misses       4401     4399    -2     
  Partials      948      948           
Flag Coverage Δ
macos 73.51% <ø> (+0.03%) ⬆️
ubuntu 73.53% <ø> (+<0.01%) ⬆️
windows 73.42% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstoykov
Copy link
Contributor

Closing this in favor of #3625

@mstoykov mstoykov closed this Mar 11, 2024
@mstoykov mstoykov deleted the v0.50-canary branch March 11, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants