Add PRs from last week to Grafana docs #1393
Conversation
|
@ppcano @pablochacin tagging you both here cause there were updates to the xk6-disruptor docs that we merged to k6-docs last week. I tried to bring them over in this PR, if you want to review them and make sure everything looks good. :) |
|
There's a version of the docs published here: https://mdr-ci.staging.k6.io/docs/refs/pull/1393/merge It will be deleted automatically in 30 days. |
grafana/k6-docs#1393 Signed-off-by: Jack Baldry <[email protected]>
docs/sources/v0.47.x/javascript-api/xk6-disruptor/faults/pod-termination.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.47.x/results-output/end-of-test/custom-summary.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
And VU: grafana/writers-toolkit#366.
It looks like it is commonly misspelt as 'vu' in this file but that's outside of the scope of this PR.
Perhaps lowercase is also an acceptable spelling though?
There was a problem hiding this comment.
I think we use lowercase 'vu' when we're referring to the property name in scripts, since that's how it's supposed to be used. It would probably be good to add it as an acceptable spelling as well. 🤓
There was a problem hiding this comment.
Ah nice. And that shouldn't be wrapped in backticks to make it code?
Vale doesn't spellcheck code so we wouldn't need the dictionary entry in that case.
There was a problem hiding this comment.
Ah, that's a good point. I updated the one instance of vus in the paragraph to use backticks, the other one is in a table and I think we should keep that as regular text... I think most of the other tables where we have properties listed they are just regular text, not code.
* Add JMeter and Oauth to dictionary grafana/k6-docs#1393 Signed-off-by: Jack Baldry <[email protected]> * Also add JUnit Signed-off-by: Jack Baldry <[email protected]> * Also add VU Signed-off-by: Jack Baldry <[email protected]> * Add Jaeger, OTel, OpenTelemetry, and Zipkin to dictionary (#367) * Add Jaeger, OTel, OpenTelemetry, and Zipkin to dictionary Signed-off-by: Jack Baldry <[email protected]> * Add Alertmanager and plural form to dictionary (#368) * Add Alertmanager and plural form to dictionary Signed-off-by: Jack Baldry <[email protected]> * Add adjective parts of speech for product names (#369) Signed-off-by: Jack Baldry <[email protected]> --------- Signed-off-by: Jack Baldry <[email protected]> --------- Signed-off-by: Jack Baldry <[email protected]> --------- Signed-off-by: Jack Baldry <[email protected]>
…ermination.md Co-authored-by: Jack Baldry <[email protected]>
Bring in the changes we've merged to k6-docs in the last week to the Grafana docs version.
#1385, #1336, #1381.