Generic modal #64
Generic modal #64
Conversation
| width: 100%; | ||
| height: 100vh; | ||
| background: rgba(0, 0, 0, 0.75); | ||
| z-index: 10; |
| .then((response) => console.debug("Bundle submitted", bundle, response)) | ||
| .catch((error) => console.error(error)); | ||
| .catch((error) => { | ||
| console.error(error) | ||
| setModal({ | ||
| message: 'Something went wrong submitting the bundle. Please try again later.', | ||
| isError: true, | ||
| }); | ||
| }); | ||
| actions.setSubmitting(false); |
There was a problem hiding this comment.
probably also worth going through the response entries and if any of the response codes don't start with 2, then add a modal message to saying that there was an error with the FHIR resource. If you'd like some example bundles which will cause an error let me know and I can make some for you
| @@ -104,6 +113,9 @@ const ReportForm: FC<Props> = (props: Props) => { | |||
| }; | |||
|
|
|||
| return ( | |||
| <> | |||
| <ModalWrapper isError={modal?.isError} modalMessage={modal?.message} onClear={() => setModal(null)} /> | |||
There was a problem hiding this comment.
I would have expected the indentation to change here.. strange
There was a problem hiding this comment.
Ah yes, my auto formatter has stopped working for some reason. I must have missed this one! I'll make sure to get prettier set up again!
src/components/UI/ModalWrapper.tsx
Outdated
| isError={isError} | ||
| header={isError ? 'Error' : "Info"} | ||
| show={!!modalMessage} | ||
| footer={<button className={classes.modal__btn} onClick={onClear}>Okay</button>} |
There was a problem hiding this comment.
Oh one thing is that maybe the okay should also change colour if there's an error - red and purple look a bit jarring to my eyes at least
There was a problem hiding this comment.
Ah yes, good call!
isError,