Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading spinner #67

Merged
merged 11 commits into from
Oct 5, 2022
Merged

Loading spinner #67

merged 11 commits into from
Oct 5, 2022

Conversation

jhughes982
Copy link
Collaborator

@jhughes982 jhughes982 commented Oct 4, 2022 •
edited
Loading

  • Intended for review after Generic modal #64
  • Added a loading spinner component that can be implemented anywhere within the application
  • Example implementation in FhirAuthoriser.tsx

@jhughes982 jhughes982 added the enhancement New feature or request label Oct 4, 2022
@jhughes982 jhughes982 requested a review from stefpiatek October 4, 2022 13:24
@jhughes982 jhughes982 self-assigned this Oct 4, 2022
@jhughes982 jhughes982 temporarily deployed to test-env October 4, 2022 13:24 Inactive
@stefpiatek stefpiatek changed the base branch from main to generic-modal October 4, 2022 15:25
Base automatically changed from generic-modal to main October 4, 2022 16:28
@jhughes982 jhughes982 temporarily deployed to test-env October 4, 2022 16:48 Inactive
@jhughes982 jhughes982 temporarily deployed to test-env October 5, 2022 09:15 Inactive
stefpiatek
stefpiatek approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 delightful!

src/components/fhir/FhirAuthoriser.tsx Outdated
<ModalWrapper isError={modal?.isError} modalMessage={modal?.message} onClear={() => setModal(null)} />

<p>Connecting to FHIR back end...</p>
Copy link
Collaborator

@stefpiatek stefpiatek Oct 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this line now as well, as it's covered in the spinner 🎉

@jhughes982 jhughes982 temporarily deployed to test-env October 5, 2022 09:22 Inactive
@jhughes982 jhughes982 merged commit c062cdb into main Oct 5, 2022
@jhughes982 jhughes982 deleted the loading-spinner branch October 5, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefpiatek stefpiatek stefpiatek approved these changes

Assignees

@jhughes982 jhughes982

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhughes982 @stefpiatek