Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tooltips in sidebars #2050 #2056

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Fix tooltips in sidebars #2050 #2056

merged 2 commits into from
Feb 27, 2025

Conversation

giovanniTramonto
Copy link
Contributor

@giovanniTramonto giovanniTramonto commented Feb 26, 2025 •
edited by justvanrossum
Loading

This fixes #2050, both issues.

Tooltip line-height. The change in ad2cb59 was related to an issue with icons while scrolling, because of their line-height. In this case tooltip inherited the 0 line-height.

Tooltip cropping. This was was caused in a4edd57

@giovanniTramonto giovanniTramonto mentioned this pull request Feb 26, 2025
Closed
@justvanrossum
Copy link
Collaborator

Please mention the bug(s) in the description so that this PR is linked to them. For example "This fixes #NNNN and fixes #MMMM".

@giovanniTramonto
Copy link
Contributor Author

Please mention the bug(s) in the description so that this PR is linked to them. For example "This fixes #NNNN and fixes #MMMM".

@justvanrossum OK adjusted above 👆

@justvanrossum
Copy link
Collaborator

Thank you!

@justvanrossum justvanrossum merged commit 1a01bda into googlefonts:main Feb 27, 2025
5 checks passed
@justvanrossum
Copy link
Collaborator

Actually, you need to literally write "fixes #NNNN" (there are some variations), or the linkage does not happen. You can tell by going to the issue and see whether it is linked to a PR. I edited now after the fact.

@giovanniTramonto
Copy link
Contributor Author

Actually, you need to literally write "fixes #NNNN" (there are some variations), or the linkage does not happen. You can tell by going to the issue and see whether it is linked to a PR. I edited now after the fact.

Ah OK, yes I see your point. Thanks. Will consider for future MRs

@giovanniTramonto giovanniTramonto deleted the fix-sidebar-cropping branch February 27, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justvanrossum justvanrossum justvanrossum approved these changes

@ollimeier ollimeier Awaiting requested review from ollimeier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tooltip] Too small padding for tooltips in sidebars
2 participants
@giovanniTramonto @justvanrossum