Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tooltip] Too small padding for tooltips in sidebars #2050

Closed
ollimeier opened this issue Feb 26, 2025 · 5 comments · Fixed by #2056
Closed

[Tooltip] Too small padding for tooltips in sidebars #2050

ollimeier opened this issue Feb 26, 2025 · 5 comments · Fixed by #2056

Comments

@ollimeier
Copy link
Collaborator

The design of the tooltips are messed up. The padding of the tooltips within sidebars are way too small.

Here are some examples:

Image Image Image

But it should look like this:

Image

This behavior is part of the 'Main' branch.
@justvanrossum
Copy link
Collaborator

We also still have undesired cropping behavior:

Image

@ollimeier
Copy link
Collaborator Author

It's related to this commit: ad2cb59

@justvanrossum
Copy link
Collaborator

@giovanniTramonto can you please have a look? This appears to be a regression.

giovanniTramonto added a commit to giovanniTramonto/fontra that referenced this issue Feb 26, 2025
@giovanniTramonto
Fix: tooltip line-height googlefonts#2050
c0d0b30
giovanniTramonto added a commit to giovanniTramonto/fontra that referenced this issue Feb 26, 2025
@giovanniTramonto
Fix: tooltip cropping in designspace panel googlefonts#2050
ff319af
@giovanniTramonto
Copy link
Contributor

Fixed #2056

@giovanniTramonto giovanniTramonto mentioned this issue Feb 26, 2025
Merged
justvanrossum added a commit that referenced this issue Feb 27, 2025
@justvanrossum
Merge pull request #2056 from giovanniTramonto/fix-sidebar-cropping
1a01bda 
Fix tooltips in sidebars #2050
@justvanrossum
Copy link
Collaborator

Fixed by #2056.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tooltips in sidebars #2050 giovanniTramonto/fontra
3 participants
@justvanrossum @giovanniTramonto @ollimeier