Merge pull request #26 from DrMarcII/textarea

Fix typing in HtmlPageLoader to work with TextAreaElements.

dart/lib/html.dart

@@ -27,7 +27,7 @@ import 'dart:mirrors' hide Comment;
 
 /// A function that will be executed after [click] and [type] and during
 /// [waitFor] and [waitForValue] to allow events to be processed. For example
-/// if using Angular's async test wrapper this should be function that calls
+/// if using Angular's async test wrapper this should be a function that calls
 /// scope.apply() and clockTick.
 typedef void SyncActionFn(Duration interval);
 
@@ -242,9 +242,11 @@ class _ElementPageLoaderElement extends HtmlPageLoaderElement {
   void type(String keys) {
     node.focus();
     _fireKeyPressEvents(node, keys);
-    if (node is InputElement) {
-      var value = (node as InputElement).value + keys;
-      (node as InputElement).value = '';
+    if (node is InputElement || node is TextAreaElement) {
+      // suppress warning by hiding field
+      var node = this.node;
+      var value = node.value + keys;
+      node.value = '';
       node.dispatchEvent(new TextEvent('textInput', data: value));
     }
     node.blur();
@@ -253,8 +255,9 @@ class _ElementPageLoaderElement extends HtmlPageLoaderElement {
 
   @override
   void clear() {
-    if (node is InputElement) {
-      (node as InputElement).value = '';
+    if (node is InputElement || node is TextAreaElement) {
+      var node = this.node;
+      node.value = '';
       node.dispatchEvent(new TextEvent('textInput', data: ''));
     } else {
       super.clear();

dart/lib/src/core.dart

@@ -309,9 +309,9 @@ abstract class _FieldInfo {
     }
 
     if (finder != null) {
-      var fieldInfo = isList ?
-          new _FinderListFieldInfo(name, finder, filters, type) :
-          new _FinderSingleFieldInfo(name, finder, filters, type, isOptional);
+      var fieldInfo = isList
+          ? new _FinderListFieldInfo(name, finder, filters, type)
+          : new _FinderSingleFieldInfo(name, finder, filters, type, isOptional);
       if (isFunction) {
         fieldInfo = new _FinderFunctionFieldInfo(fieldInfo);
       }

dart/pubspec.yaml

@@ -1,5 +1,5 @@
 name: pageloader
-version: 1.2.5
+version: 1.2.6
 author: Marc Fisher II
 description: Supports the creation of page objects that can be shared between in-browser tests and WebDriver tests.
 environment:

dart/test/html_test.dart

@@ -57,6 +57,7 @@ void main() {
           <option id='option1' value='value 1'>option 1</option>
           <option id='option2' value='value 2'>option 2</option>
         </select>
+        <textarea id='textarea'></textarea>
         <div class="outer-div">
           outer div 1
           <a-custom-tag></a-custom-tag>

dart/test/page_objects.dart

@@ -429,3 +429,8 @@ class NestedPageForGlobalTest {
   @Global(const ByTagName('table'))
   PageLoaderElement table;
 }
+
+class PageForTextAreaTypingText {
+  @ById('textarea')
+  PageLoaderElement textArea;
+}

dart/test/pageloader_test.dart

@@ -346,6 +346,17 @@ void runTests() {
       PageForGlobalTest page = loader.getInstance(PageForGlobalTest);
       expect(page.nested.table, equals(page.table));
     });
+
+    test('Type into textarea', () {
+      PageForTextAreaTypingText page =
+          loader.getInstance(PageForTextAreaTypingText);
+      page.textArea.type('some');
+      expect(page.textArea.attributes['value'], 'some');
+      page.textArea.type(' string');
+      expect(page.textArea.attributes['value'], 'some string');
+      page.textArea.clear();
+      expect(page.textArea.attributes['value'], '');
+    });
   });
 
   group('waitFor()', () {

dart/test/test_page.html

@@ -50,6 +50,7 @@
       <option id='option1' value='value 1'>option 1</option>
       <option id='option2' value='value 2'>option 2</option>
     </select>
+    <textarea id='textarea'></textarea>
     <div class="outer-div">
       outer div 1
       <a-custom-tag></a-custom-tag>