Fix clear method for TextAreaElement.

Improve TextAreaElement typing test.
google · Jan 29, 2015 · 3e32dca · 3e32dca
1 parent 93a0397
commit 3e32dca
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/dart/lib/html.dart b/dart/lib/html.dart
@@ -255,8 +255,9 @@ class _ElementPageLoaderElement extends HtmlPageLoaderElement {
 
   @override
   void clear() {
-    if (node is InputElement) {
-      (node as InputElement).value = '';
+    if (node is InputElement || node is TextAreaElement) {
+      var node = this.node;
+      node.value = '';
       node.dispatchEvent(new TextEvent('textInput', data: ''));
     } else {
       super.clear();

diff --git a/dart/test/pageloader_test.dart b/dart/test/pageloader_test.dart
@@ -350,8 +350,12 @@ void runTests() {
     test('Type into textarea', () {
       PageForTextAreaTypingText page =
           loader.getInstance(PageForTextAreaTypingText);
-      page.textArea.type('some string');
+      page.textArea.type('some');
+      expect(page.textArea.attributes['value'], 'some');
+      page.textArea.type(' string');
       expect(page.textArea.attributes['value'], 'some string');
+      page.textArea.clear();
+      expect(page.textArea.attributes['value'], '');
     });
   });