Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eczar: Version 2.000 added #4321

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Eczar: Version 2.000 added #4321

merged 1 commit into from
Feb 18, 2022

Conversation

yanone
Copy link
Collaborator

@yanone yanone commented Feb 17, 2022

2c39a75: [gftools-packager] Eczar: Version 2.000 added

@yanone yanone linked an issue Feb 17, 2022 that may be closed by this pull request
12 tasks
@yanone yanone added - Ready for Review II Commissioned Commissioned project to do I Font Upgrade III Expand glyphset more features and more language coverage labels Feb 17, 2022
@gf-bot
Copy link

gf-bot commented Feb 17, 2022

Fontbakery report

Fontbakery version: 0.8.6

[10] Eczar[wght].ttf
🔥 FAIL: Check `Google Fonts Latin Core` glyph coverage.
--- Rationale ---
Google Fonts expects that fonts in its collection support at least the minimal
set of characters defined in the `GF-latin-core` glyph-set.
  • 🔥 FAIL Missing required codepoints:

    • 0x02BB (MODIFIER LETTER TURNED COMMA)

    • 0x02BC (MODIFIER LETTER APOSTROPHE)

    • 0x200B (ZERO WIDTH SPACE)

    • 0x2032 (PRIME)

    • 0x2033 (DOUBLE PRIME)

    • 0x2191 (UPWARDS ARROW)

    • 0x2193 (DOWNWARDS ARROW)

    • 0xFEFF (ZERO WIDTH NO-BREAK SPACE)

    • And 0xFFFD (REPLACEMENT CHARACTER)
      [code: missing-codepoints]

🔥 FAIL: Check upstream.yaml file contains all required fields
--- Rationale ---
If a family has been pushed using the gftools packager, we must check that all
the required fields in the upstream.yaml file have been populated.
  • 🔥 FAIL The upstream.yaml file is missing the following fields: ['repository_url'] [code: missing-fields]
🔥 FAIL: Ensure variable fonts include an avar table.
--- Rationale ---
Most variable fonts should include an avar table to correctly define axes
progression rates.
For example, a weight axis from 0% to 100% doesn't map directly to 100 to 1000,
because a 10% progression from 0% may be too much to define the 200, while 90%
may be too little to define the 900.
If the progression rates of axes is linear, this check can be ignored. Fontmake
will also skip adding an avar table if the progression rates are linear.
However, we still recommend designers visually proof each instance is at the
desired weight, width etc.
  • 🔥 FAIL This variable font does not have an avar table. [code: missing-avar]
WARN: DESCRIPTION.en_us.html should end in a linebreak.
--- Rationale ---
Some older text-handling tools sometimes misbehave if the last line of data in a
text file is not terminated with a newline character (also known as '\n').
We know that this is a very small detail, but for the sake of keeping all
DESCRIPTION.en_us.html files uniformly formatted throughout the GFonts
collection, we chose to adopt the practice of placing this final linebreak char
on them.
  • WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: Is there kerning info for non-ligated sequences?
--- Rationale ---
Fonts with ligatures should have kerning on the corresponding non-ligated
sequences for text where ligatures aren't used (eg
https://github.com/impallari/Raleway/issues/14).
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + b
    • b + f
    • f + h
    • h + i
    • i + j
    • j + k
    • k + l
    • l + t

    [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts
--- Rationale ---
Variable font family directories kept in the google/fonts git repo may include a
static/ subdir containing static fonts.
These files are meant to be served for users that still lack support for
variable fonts in their web browsers.
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Does the font contain less than 40 CJK characters?
--- Rationale ---
Hangul has 40 characters and it's the smallest CJK writing system.
If a font contains less CJK glyphs than this writing system, we inform the user
that some glyphs may be encoded incorrectly.
  • WARN There is only one CJK glyph when there needs to be at least 40 in order to support the smallest CJK writing system, Hangul.
    The following CJK glyphs were found:
    ['uni0FD5']
    Please check that these glyphs have the correct unicodes. [code: cjk-not-enough-glyphs]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table.
--- Rationale ---
The OpenType 'meta' table originated at Apple. Microsoft added it to OT with
just two DataMap records:
- dlng: comma-separated ScriptLangTags that indicate which scripts, or languages
and scripts, with possible variants, the font is designed for
- slng: comma-separated ScriptLangTags that indicate which scripts, or languages
and scripts, with possible variants, the font supports
The slng structure is intended to describe which languages and scripts the font
overall supports. For example, a Traditional Chinese font that also contains
Latin characters, can indicate Hant,Latn, showing that it supports Hant, the
Traditional Chinese variant of the Hani script, and it also supports the Latn
script
The dlng structure is far more interesting. A font may contain various glyphs,
but only a particular subset of the glyphs may be truly "leading" in the design,
while other glyphs may have been included for technical reasons. Such a
Traditional Chinese font could only list Hant there, showing that it’s designed
for Traditional Chinese, but the font would omit Latn, because the developers
don’t think the font is really recommended for purely Latin-script use.
The tags used in the structures can comprise just script, or also language and
script. For example, if a font has Bulgarian Cyrillic alternates in the locl
feature for the cyrl BGR OT languagesystem, it could also indicate in dlng
explicitly that it supports bul-Cyrl. (Note that the scripts and languages in
meta use the ISO language and script codes, not the OpenType ones).
This check ensures that the font has the meta table containing the slng and dlng
structures.
All families in the Google Fonts collection should contain the 'meta' table.
Windows 10 already uses it when deciding on which fonts to fall back to. The
Google Fonts API and also other environments could use the data for smarter
filtering. Most importantly, those entries should be added to the Noto fonts.
In the font making process, some environments store this data in external files
already. But the meta table provides a convenient way to store this inside the
font file, so some tools may add the data, and unrelated tools may read this
data. This makes the solution much more portable and universal.
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs
--- Rationale ---
Glyphs are either accessible directly through Unicode codepoints or through
substitution rules. Any glyphs not accessible by either of these means are
redundant and serve only to increase the font's file size.
  • WARN The following glyphs could not be reached by codepoint or substitution rules:
    • uni0326.1
    • uni094D.small
    • NULL
    • dvHeadlineCandrabindu
    • dvNDRa
    • CR
    • And commaaccentturnedabovecomb
      [code: unreachable-glyphs]
WARN: Does the font contain chws and vchw features?
--- Rationale ---
The W3C recommends the addition of chws and vchw features to CJK fonts to
enhance the spacing of glyphs in environments which do not fully support JLREQ
layout rules.
The chws_tool utility (https://github.com/googlefonts/chws_tool) can be used to
add these features automatically.

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 3 7 50 9 153 0
0% 1% 3% 23% 4% 69% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS
  • DEBUG

@RosaWagner RosaWagner added --- to sandbox and removed - Ready for Review II Commissioned Commissioned project to do labels Feb 18, 2022
@RosaWagner RosaWagner merged commit 597475e into main Feb 18, 2022
@RosaWagner RosaWagner deleted the gftools_packager_ofl_eczar branch February 18, 2022 16:13
@RosaWagner RosaWagner added the II Indic / Brahmic / Thai / Tai Indic and non-latin South and East Asia scripts label Feb 23, 2022
@RosaWagner RosaWagner added --- Live Font is visible on API and removed --- to production labels Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--- Live Font is visible on API I Font Upgrade II Indic / Brahmic / Thai / Tai Indic and non-latin South and East Asia scripts III Expand glyphset more features and more language coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Eczar
3 participants