Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run prettier on examples #2068

Closed
wants to merge 10 commits into from

Conversation

alicialics
Copy link
Contributor

@alicialics alicialics commented Nov 9, 2023

The basics

Run eslint on the following examples, this will result in no changes since there are no errors detected by eslint.
Run prettier on all examples. All changes in this PR comes from prettier.

examples/blockly-svelte
examples/custom-dialogs-demo
examples/custom-generator-codelab
examples/custom-renderer-codelab
examples/custom-tooltips-demo
examples/fixed-demo
examples/generator-demo
examples/graph-demo
examples/headless-demo
examples/keyboard-navigation-codelab
examples/max-blocks-demo
examples/mirror-demo
examples/resizable-demo
examples/rtl-demo
examples/sample-app
examples/single-direction-scroll-demo
examples/toolbox-demo

The details

Resolves

#1981

Proposed Changes

the ignored examples contains one or more eslint errors and so it's not tackled here

Reason for Changes

#1981

Test Coverage

N/A

Documentation

N/A

Additional Information

Svelte example is broken. I will open a separate PR
cc @maribethb

@alicialics alicialics requested a review from a team as a code owner November 9, 2023 23:16
@alicialics alicialics requested review from BeksOmega and removed request for a team November 9, 2023 23:16
@BeksOmega BeksOmega assigned maribethb and unassigned BeksOmega Nov 10, 2023
@BeksOmega BeksOmega requested review from maribethb and removed request for BeksOmega November 10, 2023 16:56
@alicialics alicialics changed the title chore: run eslint and prettier on some examples chore: run prettier on examples Nov 10, 2023
Copy link
Contributor

@maribethb maribethb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this!

@alicialics alicialics requested a review from maribethb November 11, 2023 06:19
@maribethb maribethb mentioned this pull request Jan 30, 2024
1 task
@maribethb
Copy link
Contributor

I incorporated these commits into #2182 along with further updating examples based on current version of examples and prettier. Thanks for your work on this! Sorry this sat for a while.

@maribethb maribethb closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants