-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable linting and formatting in examples #1981
Comments
There were 1k+ eslint errors, but most of them were caused by a few select plugins (eg interpreter-demo). Ignoring them brings down the number to 125 errors (and many more warnings). It might be simpler to do it example by example to make it easier to review since not all of changes are trivial and its hard to guarantee a change is correct without actually running it and hopefully test what you've changed. We can use the re-include pattern to ignore all examples but a project you are working on
|
Believe this was closed by #2070, correct me if I'm wrong @alicialics ! |
Check for duplicates
Component
all examples
Problem
Current behavior: examples are not linted, nothing is formatted
After #1946: examples are excluded from linting and formatting
We want to lint and format examples as well
Request
examples
from the ignore list ineslint.config.js
examples
from the ignore list in.prettierignore
npm run lint:fix
and commit the changes.npm run format
and commit the changes.npm run lint
, manually fix any remaining lint errors or warnings, and commit the changes.It is important that steps 4, 5, and 6 each be committed separately, as this will make reviewing and rebasing the PR easier.
Note that some examples specify their own lint command and I'm not sure how this will interact with the new flat config. If you attempt this process and find issues with linting any of the examples, let us know in the comments!
Alternatives considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: