🩹 Fix bad ports #102
Merged
🩹 Fix bad ports #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnel
reviewed
Jun 1, 2024
pyglotaran_examples/ex_spectral_constraints/models/scheme_equal_area_penalties.yml
Show resolved
Hide resolved
Added dataset scale parameters experiment in the simultaneous_analysis_3d_nodisp. Each dataset now has its own scale parameter.
TRF needs a minimum of 9 iterations to fully optimize.
From comments in script:
```py
maximum_number_function_evaluations=9, # TRF needs 8m LM needs 127
# optimization_method="Levenberg-Marquardt", #LM needs nfev=127
```
🧰 Use ruff 🧰👌 Strip papermill notebook meta data
This adds the id and metadata.tags metadata, but this should be a one time thin and not cause further diffs in the furure. And ofc there were also some formatting changes.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
1 task
jsnel
pushed a commit
to glotaran/pyglotaran
that referenced
this pull request
Jun 2, 2024
…1462) With this change the integration tests used the examples ported to the staging syntax (see glotaran/pyglotaran-examples#101 and glotaran/pyglotaran-examples#102) Change summary 🚇 Use pyglotaran-examples@staging_rewrite for CI integration tests
jsnel
pushed a commit
to jsnel/pyglotaran
that referenced
this pull request
Jun 2, 2024
…lotaran#1462) With this change the integration tests used the examples ported to the staging syntax (see glotaran/pyglotaran-examples#101 and glotaran/pyglotaran-examples#102) Change summary 🚇 Use pyglotaran-examples@staging_rewrite for CI integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some errors discovered in the ports of examples for staging (introduced in #101).
Change summary
Checklist