-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🩹 Fix bad ports (2) #104
🩹 Fix bad ports (2) #104
Conversation
43f669d
to
6d9f470
Compare
This is only needed so the const parameters are part of the optimized parameters for result comparisons
🧙 Sourcery is reviewing your pull request! Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
- Add scaling parameters to experiments for 2 datasets study - Set number of iterations to be the same as on main - Make inputs explicit (for easier comparison to main)
Noteable changes: - spectral guidance example (scheme) - spectral constraints notebook - test/sim 3d disp (scheme, weighs) And corrected number of iterations in some places.
Found what the cause of the CI fail (in sim-3d-weight) here was. The issues is/was that the parameter values for (some of the element of) the activation would go wild. Specifically with non-negative=true and optimization method=lm. Ultimatelly this would lead to: The value of 0.0 for irf.width2 causes a division by zero in The exact 0 value is most likely because the original estimate (per the optimizerI for this value is -96, which with And that this value is going wild, is because scaling is not working properly 😄 because of glotaran/pyglotaran#1463 So we find ourself in a proper chicken-egg situation here, so for the CI to pass here, I must first merge in glotaran/pyglotaran#1461 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewer and (extensively) tested ok. Large step in validation parity!
Follow up PR for #102 with refinements based on comparison errors and the work in #103
Change summary
Checklist