-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed custom json encoders #6741
Conversation
9b46ca5
to
01cd16f
Compare
@AndrewChubatiuk , thanks for the PR. Could you explain the change + test it somehow before we merge? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6741 +/- ##
=======================================
Coverage 63.37% 63.37%
=======================================
Files 162 162
Lines 13170 13170
Branches 1819 1819
=======================================
Hits 8347 8347
Misses 4532 4532
Partials 291 291
|
01cd16f
to
9e79a25
Compare
this change is actually a typo fix for custom json encoders loading which was introduced after migration of almost all json columns from TEXT to JSONB column type in postgres |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging because it seems it'll fix an issue, but I'm not sure I understand the change. Please try to be more descriptive when creating PRs so that everyone can follow along!
What type of PR is this?
Fixes #6737
Description
How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)