Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linting #6745

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix linting #6745

merged 1 commit into from
Feb 6, 2024

Conversation

guidopetri
Copy link
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

One of the recent commits to master broke the linting, so this PR fixes that.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@guidopetri
Copy link
Contributor Author

guidopetri commented Feb 6, 2024

@AndrewChubatiuk @justinclift it looks like pull_request_target is not doing its job correctly here. It's running black and ruff vs master, but we want it to run vs the PR branch. That would explain why #6741 checks succeeded in the PR, but failed on master.

edit: I also think this might mean that even for a PR that breaks a test, it'll still pass the CI.

@guidopetri guidopetri merged commit ab39283 into master Feb 6, 2024
11 of 13 checks passed
@guidopetri guidopetri deleted the gpetri/fix-linting branch February 6, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant