Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent duplicate field mappings in various plugins #990

Merged
merged 4 commits into from
Jan 21, 2025
+141 −27

add tests and implement review feedback

6c619b1
Select commit
Loading
Failed to load commit list.
Merged

Fix inconsistent duplicate field mappings in various plugins #990

add tests and implement review feedback
6c619b1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jan 21, 2025 in 1s

73.07% of diff hit (target 77.76%)

View this Pull Request on Codecov

73.07% of diff hit (target 77.76%)

Annotations

Check warning on line 87 in dissect/target/plugins/os/unix/shadow.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dissect/target/plugins/os/unix/shadow.py#L86-L87 

Added lines #L86 - L87 were not covered by tests

Check warning on line 94 in dissect/target/plugins/os/unix/shadow.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dissect/target/plugins/os/unix/shadow.py#L93-L94 

Added lines #L93 - L94 were not covered by tests

Check warning on line 101 in dissect/target/plugins/os/unix/shadow.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dissect/target/plugins/os/unix/shadow.py#L100-L101 

Added lines #L100 - L101 were not covered by tests

Check warning on line 174 in dissect/target/plugins/os/unix/shadow.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dissect/target/plugins/os/unix/shadow.py#L174 

Added line #L174 was not covered by tests
View more details on Codecov