Fix inconsistent duplicate field mappings in various plugins #990
+142
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Horofic
requested changes
Jan 16, 2025
JSCU-CNI
force-pushed
the
fix/inconsistent-field-mappings
branch
from
99cf36f to
6c619b1
Compare
Horofic
approved these changes
Jan 21, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #990 +/- ##
==========================================
- Coverage 77.76% 77.76% -0.01%
==========================================
Files 327 327
Lines 28627 28653 +26
==========================================
+ Hits 22261 22281 +20
- Misses 6366 6372 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Horofic
requested changes
Jan 21, 2025
| assert results[3].name == "no_int_fields" | ||
| assert results[3].last_change is None | ||
| assert ( | ||
| "Unable to parse last_change shadow value in /etc/shadow: invalid literal for int() with base 10: 'string' ('string')" |
There was a problem hiding this comment.
Suggested change
| "Unable to parse last_change shadow value in /etc/shadow: invalid literal for int() with base 10: 'string' ('string')" | |
| "Unable to parse last_change shadow value in /etc/shadow: invalid literal for int() with base 10: 'string' ('string')" # noqa:E501 |
| @@ -69,6 +69,7 @@ def create_record( | |||
| create: str, | |||
| target: Target, | |||
| ) -> TargetRecordDescriptor: | |||
|
|
|||
There was a problem hiding this comment.
Black trips over this line during the linting check.
Suggested change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of an ongoing effort to fix inconsistencies in record field types across dissect.