Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compatibility checks on various plugins #1008

Merged
merged 5 commits into from
Jan 30, 2025

Merge branch 'main' into improvement/plugin-compat-checks

092c118
Select commit
Loading
Failed to load commit list.
Merged

Improve compatibility checks on various plugins #1008

Merge branch 'main' into improvement/plugin-compat-checks
092c118
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 30, 2025 in 1s

77.91% (-0.02%) compared to ca216f4

View this Pull Request on Codecov

77.91% (-0.02%) compared to ca216f4

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 77.91%. Comparing base (ca216f4) to head (092c118).

Files with missing lines Patch % Lines
dissect/target/plugins/filesystem/walkfs.py 42.85% 4 Missing ⚠️
dissect/target/plugins/filesystem/ntfs/usnjrnl.py 33.33% 2 Missing ⚠️
dissect/target/plugins/general/osinfo.py 33.33% 2 Missing ⚠️
dissect/target/plugins/os/windows/env.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1008      +/-   ##
==========================================
- Coverage   77.93%   77.91%   -0.02%     
==========================================
  Files         327      327              
  Lines       28677    28689      +12     
==========================================
+ Hits        22349    22354       +5     
- Misses       6328     6335       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.