-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve compatibility checks on various plugins #1008
Improve compatibility checks on various plugins #1008
Conversation
Can you sneak this in too? I've had this pending locally for a while but didn't get around to making a PR for it: diff --git a/dissect/target/plugins/filesystem/walkfs.py b/dissect/target/plugins/filesystem/walkfs.py
index 9e2a989f..5404b5d1 100644
--- a/dissect/target/plugins/filesystem/walkfs.py
+++ b/dissect/target/plugins/filesystem/walkfs.py
@@ -37,6 +37,10 @@ class WalkFSPlugin(Plugin):
@arg("--walkfs-path", default="/", help="path to recursively walk")
def walkfs(self, walkfs_path: str = "/") -> Iterator[FilesystemRecord]:
"""Walk a target's filesystem and return all filesystem entries."""
+ if not self.target.fs.exists(walkfs_path):
+ self.target.log.warning("Path does not exist: %s", walkfs_path)
+ return
+
for entry in self.target.fs.recurse(walkfs_path):
try:
yield generate_record(self.target, entry) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
- Coverage 77.93% 77.91% -0.02%
==========================================
Files 327 327
Lines 28677 28689 +12
==========================================
+ Hits 22349 22354 +5
- Misses 6328 6335 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Erik Schamper <[email protected]>
Co-authored-by: Erik Schamper <[email protected]>
No description provided.