Skip to content

group orders: display deposit, tolerance only if necessary #770

group orders: display deposit, tolerance only if necessary

group orders: display deposit, tolerance only if necessary #770

Triggered via pull request December 17, 2024 11:57
Status Failure
Total duration 44s
Artifacts

rubocop.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 1 warning
test: app/models/concerns/price_calculation.rb#L6
Style/OptionalBooleanParameter: Prefer keyword arguments for arguments with a boolean default value; use `include_deposit: true` instead of `include_deposit = true`.
test: app/models/concerns/price_calculation.rb#L16
Lint/UselessAssignment: Useless assignment to variable - `include_deposit`.
test: app/models/concerns/price_calculation.rb#L24
Lint/DeprecatedConstants: Use `false` instead of `FALSE`, deprecated since Ruby 2.4.
test: app/models/concerns/price_calculation.rb#L25
Layout/TrailingWhitespace: Trailing whitespace detected.
test: app/models/order.rb#L1
Metrics/ClassLength: Class has too many lines. [308/304]
test
Process completed with exit code 1.
test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636